[dpdk-stable] [dpdk-dev] [PATCH v3] net/ice: fix setting max frame size
Ye Xiaolong
xiaolong.ye at intel.com
Wed Oct 30 06:21:55 CET 2019
Hi, Jiaqi
On 10/29, Min JiaqiX wrote:
>Max frame size is not set to HW, so packets above the MTU
>do not get dropped by HW. The patch fixed the issue.
>
>Fixes: 50370662b727 ("net/ice: support device and queue ops")
>Cc: stable at dpdk.org
>
>Signed-off-by: Min JiaqiX <jiaqix.min at intel.com>
>Reviewed-by: Xiaolong Ye <xiaolong.ye at intel.com>
Sorry, the Reviewed-by was given by accident in V1.
>---
>v3:
>* Changed Fixes line.
>v2:
>* Changed commit message.
>---
> drivers/net/ice/ice_ethdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index 022b58c01..403305cfb 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
>
> pf->adapter_stopped = false;
>
>+ /* Set the max frame size */
>+ ice_aq_set_mac_cfg(hw,
>+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>+
As I commented in V2, what if user doesn't set mtu, then the max_rx_pkt_len
would be 0, do we need a default max frame value in this case?
Thanks,
Xiaolong
> return 0;
>
> /* stop the started queues if failed to start all queues */
>--
>2.17.1
>
More information about the stable
mailing list