[dpdk-stable] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa

Ferruh Yigit ferruh.yigit at intel.com
Wed Sep 4 10:17:01 CEST 2019


On 8/19/2019 10:56 PM, Louis Luo wrote:
> Hi Maxime,
> 
> Thanks for the fix. Actually Yong and I had some discussion about removing TX IP CSUM offload flag last August and I did prepare a fix but later forgot to submit. Anyway your fix is fine.
> 
> Thanks,
> Louis
> 
> On 8/13/19, 6:30 AM, "Maxime Leroy" <maxime.leroy at 6wind.com> wrote:
> 
>     The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
>     having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
>     DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.
>     
>     This issue has been introduced with the new Rx offload
>     API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been
>     added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support
>     it.
>     
>     To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from
>     tx/rx offload capa.
>     
>     Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API")
>     Cc: llouis at vmware.com
>     Cc: stable at dpdk.org
>     
>     Signed-off-by: Maxime Leroy <maxime.leroy at 6wind.com>

Acked-by: Yong Wang <yongwang at vmware.com>

Applied to dpdk-next-net/master, thanks.

(Carried the ack from another email)


More information about the stable mailing list