[dpdk-stable] patch 'acl: fix undefined behavior of bit shifts' has been queued to LTS release 18.11.3

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/12/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/551a27e526cbb569eb496e0a21f8e09c96ce8184

Thanks.

Kevin Traynor

---
>From 551a27e526cbb569eb496e0a21f8e09c96ce8184 Mon Sep 17 00:00:00 2001
From: Aaron Conole <aconole at redhat.com>
Date: Wed, 31 Jul 2019 11:43:11 -0400
Subject: [PATCH] acl: fix undefined behavior of bit shifts

[ upstream commit 5924381221b022b589bef88bacea8a59a7bf6c8b ]

Left-shift of an integer constant is represented as 'int' type, but a left
shift of 1 by 31 bits in 'int' is undefined.  Use the U suffix to force
a representation as unsigned.

Caught while running with ubsan under gcc.

Fixes: dc276b5780c2 ("acl: new library")

Signed-off-by: Aaron Conole <aconole at redhat.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
---
 lib/librte_acl/acl_bld.c | 6 +++---
 lib/librte_acl/acl_gen.c | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c
index b82191f42..b06bbe920 100644
--- a/lib/librte_acl/acl_bld.c
+++ b/lib/librte_acl/acl_bld.c
@@ -321,5 +321,5 @@ acl_add_ptr_range(struct acl_build_context *context,
 		if (n >= low && n <= high)
 			bitset.bits[n / (sizeof(bits_t) * 8)] |=
-				1 << (n % (sizeof(bits_t) * 8));
+				1U << (n % (sizeof(bits_t) * CHAR_BIT));
 
 	return acl_add_ptr(context, root, node, &bitset);
@@ -344,5 +344,5 @@ acl_gen_mask(struct rte_acl_bitset *bitset, uint32_t value, uint32_t mask)
 			range++;
 			bitset->bits[n / (sizeof(bits_t) * 8)] |=
-				1 << (n % (sizeof(bits_t) * 8));
+				1U << (n % (sizeof(bits_t) * CHAR_BIT));
 		}
 	}
@@ -973,5 +973,5 @@ build_trie(struct acl_build_context *context, struct rte_acl_build_rule *head,
 
 		for (m = context->cfg.num_categories; 0 != m--; ) {
-			if (rule->f->data.category_mask & (1 << m)) {
+			if (rule->f->data.category_mask & (1U << m)) {
 				end->mrt->results[m] = rule->f->data.userdata;
 				end->mrt->priority[m] = rule->f->data.priority;
diff --git a/lib/librte_acl/acl_gen.c b/lib/librte_acl/acl_gen.c
index 35a0140b4..f1b9d12f1 100644
--- a/lib/librte_acl/acl_gen.c
+++ b/lib/librte_acl/acl_gen.c
@@ -134,5 +134,5 @@ acl_node_fill_dfa(const struct rte_acl_node *node,
 
 			if (bits->bits[n / (sizeof(bits_t) * CHAR_BIT)] &
-				(1 << (n % (sizeof(bits_t) * CHAR_BIT)))) {
+				(1U << (n % (sizeof(bits_t) * CHAR_BIT)))) {
 
 				dfa[n] = resolved ? child->node_index : x;
@@ -176,5 +176,5 @@ acl_count_sequential_groups(struct rte_acl_bitset *bits, int zero_one)
 	for (n = 0; n < QRANGE_MIN; n++) {
 		if (bits->bits[n / (sizeof(bits_t) * 8)] &
-				(1 << (n % (sizeof(bits_t) * 8)))) {
+				(1U << (n % (sizeof(bits_t) * CHAR_BIT)))) {
 			if (zero_one == 1 && last_bit != 1)
 				ranges++;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-09-05 10:36:49.394441440 +0100
+++ 0031-acl-fix-undefined-behavior-of-bit-shifts.patch	2019-09-05 10:36:47.528700091 +0100
@@ -1 +1 @@
-From 5924381221b022b589bef88bacea8a59a7bf6c8b Mon Sep 17 00:00:00 2001
+From 551a27e526cbb569eb496e0a21f8e09c96ce8184 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5924381221b022b589bef88bacea8a59a7bf6c8b ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org