[dpdk-stable] patch 'usertools: fix input handling in telemetry script' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Thu Sep 5 12:17:54 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/12/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/791dcd207781bf740167b8d449d452f01aca5ff9

Thanks.

Kevin Traynor

---
>From 791dcd207781bf740167b8d449d452f01aca5ff9 Mon Sep 17 00:00:00 2001
From: Andrius Sirvys <andrius.sirvys at intel.com>
Date: Thu, 8 Aug 2019 15:37:52 +0100
Subject: [PATCH] usertools: fix input handling in telemetry script

[ upstream commit a667070b09bb8cfbd83912045391d877ed88725e ]

This commit removes the unnecesarry ast.literal_eval() function call
from the input handling, which now relies just on raw_input() to get
its input.

Fixes: 53f293c9a783 ("usertools: replace unsafe input function")

Signed-off-by: Andrius Sirvys <andrius.sirvys at intel.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
---
 usertools/dpdk-telemetry-client.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index 4afa2f84c..e0587022c 100644
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -77,5 +77,5 @@ class Client:
     def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
         print("\nPlease enter the number of times you'd like to continuously request Metrics:")
-        n_requests = int(ast.literal_eval(raw_input("\n:")))
+        n_requests = int(raw_input("\n:"))
         print("\033[F") #Removes the user input from screen, cleans it up
         print("\033[K")
@@ -92,5 +92,5 @@ class Client:
 
             try:
-                self.choice = int(ast.literal_eval(raw_input("\n:")))
+                self.choice = int(raw_input("\n:"))
                 print("\033[F") #Removes the user input for screen, cleans it up
                 print("\033[K")
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-09-05 10:36:50.780788204 +0100
+++ 0054-usertools-fix-input-handling-in-telemetry-script.patch	2019-09-05 10:36:47.568699134 +0100
@@ -1 +1 @@
-From a667070b09bb8cfbd83912045391d877ed88725e Mon Sep 17 00:00:00 2001
+From 791dcd207781bf740167b8d449d452f01aca5ff9 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a667070b09bb8cfbd83912045391d877ed88725e ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 4b0502ff9..60fe97af7 100755
+index 4afa2f84c..e0587022c 100644
@@ -23 +24 @@
-@@ -79,5 +79,5 @@ class Client:
+@@ -77,5 +77,5 @@ class Client:
@@ -30 +31 @@
-@@ -100,5 +100,5 @@ class Client:
+@@ -92,5 +92,5 @@ class Client:


More information about the stable mailing list