[dpdk-stable] [PATCH 18.11 0/1] Enable __BSD_VISIBLE

Kevin Traynor ktraynor at redhat.com
Wed Sep 25 19:12:41 CEST 2019


This backport is needed for 18.11 as the below commit
[Fixes: 54e4657b2385 ("net: define IPv4 IHL and VHL")]
requires that __BSD_VISIBLE is defined for <sys/types.h>
in FreeBSD.

Otherwise, there is a build error on FreeBSD similar to the one
originally reported here
http://inbox.dpdk.org/stable/3d694042-dbe9-7560-5912-d865da048c7c@intel.com/

The other option is to revert the following commits from branch 18.11.

commit d8084ac1f9c74ce9fe61b26c9d4198d872d5fc7e
Author: Saleh Alsouqi <salehals at mellanox.com>
Date:   Thu Jul 4 07:33:22 2019 +0000

    app/testpmd: fix MPLS IPv4 encapsulation fields
    
    [ upstream commit a97ec9ba45d4357c172df71be3fcf601dfdb8147 ]
    
    Having version and ihl set to 0 would result in a
    corrupted/incorrect encapsulating packet for MPLS,
    this commit sets these fields to 4 and 5 respectively
    as defined in librte_net/rte_ip.h.
    
    Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation")
    Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation")
    
    Signed-off-by: Saleh Alsouqi <salehals at mellanox.com>
    Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>

commit 54e4657b238593c633367a2dda48ecf4e04249bb
Author: Saleh Alsouqi <salehals at mellanox.com>
Date:   Thu Jul 4 07:33:19 2019 +0000

    net: define IPv4 IHL and VHL
    
    [ upstream commit 2318d8d5456532e8022d324937a77a416b701d2b ]
    
    Define IPv4 Minimum IHL and VHL according to rfc791 (see [1])
    
        "The Version field indicates the format of the
        internet header."
    
        "Internet Header Length (ihl) is the length of the
        internet header in 32 bit words, and thus points
        to the beginning of the data. Note that
        the minimum value for a correct header is 5."
    
    [1] https://tools.ietf.org/html/rfc791
    
    Signed-off-by: Saleh Alsouqi <salehals at mellanox.com>
    Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>

Marcin Smoczynski (1):
  build: enable BSD features visibility for FreeBSD

 app/meson.build               | 3 ---
 config/meson.build            | 8 ++++++++
 drivers/meson.build           | 3 ---
 examples/meson.build          | 3 ---
 lib/meson.build               | 3 ---
 meson.build                   | 6 +++++-
 mk/target/generic/rte.vars.mk | 5 +++++
 7 files changed, 18 insertions(+), 13 deletions(-)

-- 
2.20.1



More information about the stable mailing list