[dpdk-stable] patch 'event/dpaa: remove dead code' has been queued to stable release 19.11.4

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Aug 6 11:53:32 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/08/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 31a7eed72c28508aac5f7fbf2ca9b2f3ca2b765d Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Fri, 17 Jul 2020 19:31:52 +0800
Subject: [PATCH] event/dpaa: remove dead code

[ upstream commit fea678742606d794240bca2c15811c357bf0c298 ]

Fix logical dead code.

Coverity issue: 323495
Fixes: 77b5311d0ece ("event/dpaa: support select based event")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
---
 drivers/event/dpaa/dpaa_eventdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
index a7d57edce..29b18fe62 100644
--- a/drivers/event/dpaa/dpaa_eventdev.c
+++ b/drivers/event/dpaa/dpaa_eventdev.c
@@ -173,7 +173,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
 	int ret;
 	u16 ch_id;
 	void *buffers[8];
-	u32 num_frames, i, irq = 0;
+	u32 num_frames, i;
 	uint64_t cur_ticks = 0, wait_time_ticks = 0;
 	struct dpaa_port *portal = (struct dpaa_port *)port;
 	struct rte_mbuf *mbuf;
@@ -222,8 +222,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
 	do {
 		/* Lets dequeue the frames */
 		num_frames = qman_portal_dequeue(ev, nb_events, buffers);
-		if (irq)
-			irq = 0;
 		if (num_frames)
 			break;
 		cur_ticks = rte_get_timer_cycles();
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-06 10:53:15.966028334 +0100
+++ 0004-event-dpaa-remove-dead-code.patch	2020-08-06 10:53:15.700595422 +0100
@@ -1,13 +1,14 @@
-From fea678742606d794240bca2c15811c357bf0c298 Mon Sep 17 00:00:00 2001
+From 31a7eed72c28508aac5f7fbf2ca9b2f3ca2b765d Mon Sep 17 00:00:00 2001
 From: Yunjian Wang <wangyunjian at huawei.com>
 Date: Fri, 17 Jul 2020 19:31:52 +0800
 Subject: [PATCH] event/dpaa: remove dead code
 
+[ upstream commit fea678742606d794240bca2c15811c357bf0c298 ]
+
 Fix logical dead code.
 
 Coverity issue: 323495
 Fixes: 77b5311d0ece ("event/dpaa: support select based event")
-Cc: stable at dpdk.org
 
 Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
 Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
@@ -16,10 +17,10 @@
  1 file changed, 1 insertion(+), 3 deletions(-)
 
 diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
-index a3c138b7a..b5ae87a4e 100644
+index a7d57edce..29b18fe62 100644
 --- a/drivers/event/dpaa/dpaa_eventdev.c
 +++ b/drivers/event/dpaa/dpaa_eventdev.c
-@@ -174,7 +174,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
+@@ -173,7 +173,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
  	int ret;
  	u16 ch_id;
  	void *buffers[8];
@@ -28,7 +29,7 @@
  	uint64_t cur_ticks = 0, wait_time_ticks = 0;
  	struct dpaa_port *portal = (struct dpaa_port *)port;
  	struct rte_mbuf *mbuf;
-@@ -223,8 +223,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
+@@ -222,8 +222,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
  	do {
  		/* Lets dequeue the frames */
  		num_frames = qman_portal_dequeue(ev, nb_events, buffers);


More information about the stable mailing list