[dpdk-stable] patch 'net/qede: remove dead code' has been queued to stable release 19.11.4

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Aug 6 11:53:49 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/08/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 491fd352e1351f40b7255e916b0ecac9d148105b Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Fri, 17 Jul 2020 19:16:23 +0800
Subject: [PATCH] net/qede: remove dead code

[ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ]

This patch removes logically dead code reported by coverity.

Coverity issue: 261777, 261778
Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Rasesh Mody <rmody at marvell.com>
---
 drivers/net/qede/qede_rxtx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
index 3c55c0efd..ab69cba17 100644
--- a/drivers/net/qede/qede_rxtx.c
+++ b/drivers/net/qede/qede_rxtx.c
@@ -647,8 +647,6 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)
 
 	for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
 		fp = &qdev->fp_array[sb_idx];
-		if (!fp)
-			continue;
 		fp->sb_info = rte_calloc("sb", 1, sizeof(struct ecore_sb_info),
 				RTE_CACHE_LINE_SIZE);
 		if (!fp->sb_info) {
@@ -678,8 +676,6 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev)
 
 	for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
 		fp = &qdev->fp_array[sb_idx];
-		if (!fp)
-			continue;
 		DP_INFO(edev, "Free sb_info index 0x%x\n",
 				fp->sb_info->igu_sb_id);
 		if (fp->sb_info) {
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-06 10:53:16.630642463 +0100
+++ 0021-net-qede-remove-dead-code.patch	2020-08-06 10:53:15.792597243 +0100
@@ -1,13 +1,14 @@
-From d123f83c43085d03e0c2e37f8174577189711fdb Mon Sep 17 00:00:00 2001
+From 491fd352e1351f40b7255e916b0ecac9d148105b Mon Sep 17 00:00:00 2001
 From: Yunjian Wang <wangyunjian at huawei.com>
 Date: Fri, 17 Jul 2020 19:16:23 +0800
 Subject: [PATCH] net/qede: remove dead code
 
+[ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ]
+
 This patch removes logically dead code reported by coverity.
 
 Coverity issue: 261777, 261778
 Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
-Cc: stable at dpdk.org
 
 Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
 Acked-by: Rasesh Mody <rmody at marvell.com>
@@ -16,7 +17,7 @@
  1 file changed, 4 deletions(-)
 
 diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
-index 9878ba50e..ea264f59d 100644
+index 3c55c0efd..ab69cba17 100644
 --- a/drivers/net/qede/qede_rxtx.c
 +++ b/drivers/net/qede/qede_rxtx.c
 @@ -647,8 +647,6 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)


More information about the stable mailing list