[dpdk-stable] patch 'vhost: fix virtio ready flag check' has been queued to LTS release 18.11.10

Kevin Traynor ktraynor at redhat.com
Thu Aug 20 17:33:27 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/25/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/3cb4625e7b526db21cf96ae34a16d3dae7f4c7ea

Thanks.

Kevin.

---
>From 3cb4625e7b526db21cf96ae34a16d3dae7f4c7ea Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Mon, 6 Jul 2020 13:24:45 +0200
Subject: [PATCH] vhost: fix virtio ready flag check

[ upstream commit 1c3df72bda9893784267d02d2c6a3fd0047c38cd ]

Before checking whether the device is ready is done
a check on whether the RUNNING flag is set. Then the
READY flag is set if virtio_is_ready() returns true.

While it seems to not cause any issue, it makes more
sense to check whether the READY flag is set and not
the RUNNING one.

Fixes: c0674b1bc898 ("vhost: move the device ready check at proper place")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
---
 lib/librte_vhost/vhost_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 4ed75104b9..c88275c24f 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -2289,5 +2289,5 @@ skip_to_reply:
 	}
 
-	if (!(dev->flags & VIRTIO_DEV_RUNNING) && virtio_is_ready(dev)) {
+	if (!(dev->flags & VIRTIO_DEV_READY) && virtio_is_ready(dev)) {
 		dev->flags |= VIRTIO_DEV_READY;
 
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-20 16:26:16.644268315 +0100
+++ 0022-vhost-fix-virtio-ready-flag-check.patch	2020-08-20 16:26:15.808324179 +0100
@@ -1 +1 @@
-From 1c3df72bda9893784267d02d2c6a3fd0047c38cd Mon Sep 17 00:00:00 2001
+From 3cb4625e7b526db21cf96ae34a16d3dae7f4c7ea Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1c3df72bda9893784267d02d2c6a3fd0047c38cd ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index aa8605523a..bac3e89713 100644
+index 4ed75104b9..c88275c24f 100644
@@ -27,2 +28,2 @@
-@@ -2843,5 +2843,5 @@ skip_to_post_handle:
- 
+@@ -2289,5 +2289,5 @@ skip_to_reply:
+ 	}



More information about the stable mailing list