[dpdk-stable] patch 'net/qede: remove dead code' has been queued to LTS release 18.11.10

Kevin Traynor ktraynor at redhat.com
Fri Aug 28 12:12:58 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/3eccb8b4fb75988a0130a6eab6b5fc8d152d415c

Thanks.

Kevin.

---
>From 3eccb8b4fb75988a0130a6eab6b5fc8d152d415c Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Fri, 17 Jul 2020 19:16:23 +0800
Subject: [PATCH] net/qede: remove dead code

[ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ]

This patch removes logically dead code reported by coverity.

Coverity issue: 261777, 261778
Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Rasesh Mody <rmody at marvell.com>
---
 drivers/net/qede/qede_rxtx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
index a72c9aa333..0ccfea4912 100644
--- a/drivers/net/qede/qede_rxtx.c
+++ b/drivers/net/qede/qede_rxtx.c
@@ -648,6 +648,4 @@ int qede_alloc_fp_resc(struct qede_dev *qdev)
 	for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
 		fp = &qdev->fp_array[sb_idx];
-		if (!fp)
-			continue;
 		fp->sb_info = rte_calloc("sb", 1, sizeof(struct ecore_sb_info),
 				RTE_CACHE_LINE_SIZE);
@@ -679,6 +677,4 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev)
 	for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
 		fp = &qdev->fp_array[sb_idx];
-		if (!fp)
-			continue;
 		DP_INFO(edev, "Free sb_info index 0x%x\n",
 				fp->sb_info->igu_sb_id);
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-28 11:03:26.698000089 +0100
+++ 0032-net-qede-remove-dead-code.patch	2020-08-28 11:03:25.984955920 +0100
@@ -1 +1 @@
-From d123f83c43085d03e0c2e37f8174577189711fdb Mon Sep 17 00:00:00 2001
+From 3eccb8b4fb75988a0130a6eab6b5fc8d152d415c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d123f83c43085d03e0c2e37f8174577189711fdb ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 9878ba50ea..ea264f59d7 100644
+index a72c9aa333..0ccfea4912 100644



More information about the stable mailing list