[dpdk-stable] patch 'net/bonding: fix dead loop on RSS RETA update' has been queued to LTS release 18.11.10

Kevin Traynor ktraynor at redhat.com
Fri Aug 28 12:13:05 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/6ae8b77e3ebb3a58d800abd994754713e8d00dd4

Thanks.

Kevin.

---
>From 6ae8b77e3ebb3a58d800abd994754713e8d00dd4 Mon Sep 17 00:00:00 2001
From: Zhiguang He <hezhiguang3 at huawei.com>
Date: Sun, 2 Aug 2020 20:27:27 +0800
Subject: [PATCH] net/bonding: fix dead loop on RSS RETA update

[ upstream commit eb8939538fddced05b906c34ba9f545bf6717ad2 ]

When parameter reta_size < RTE_RETA_GROUP_SIZE, reta_count will be 0.
Then this function will be deadloop.

Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")

Signed-off-by: Zhiguang He <hezhiguang3 at huawei.com>
Acked-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 8b410ff19b..0189a3d446 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2671,5 +2671,6 @@ bond_ethdev_rss_reta_update(struct rte_eth_dev *dev,
 
 	 /* Copy RETA table */
-	reta_count = reta_size / RTE_RETA_GROUP_SIZE;
+	reta_count = (reta_size + RTE_RETA_GROUP_SIZE - 1) /
+			RTE_RETA_GROUP_SIZE;
 
 	for (i = 0; i < reta_count; i++) {
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-08-28 11:03:26.837770642 +0100
+++ 0039-net-bonding-fix-dead-loop-on-RSS-RETA-update.patch	2020-08-28 11:03:25.991955973 +0100
@@ -1 +1 @@
-From eb8939538fddced05b906c34ba9f545bf6717ad2 Mon Sep 17 00:00:00 2001
+From 6ae8b77e3ebb3a58d800abd994754713e8d00dd4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit eb8939538fddced05b906c34ba9f545bf6717ad2 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 116e2f29de..cdbd8151ed 100644
+index 8b410ff19b..0189a3d446 100644
@@ -22 +23 @@
-@@ -2936,5 +2936,6 @@ bond_ethdev_rss_reta_update(struct rte_eth_dev *dev,
+@@ -2671,5 +2671,6 @@ bond_ethdev_rss_reta_update(struct rte_eth_dev *dev,



More information about the stable mailing list