[dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation

Kevin Traynor ktraynor at redhat.com
Wed Dec 2 15:42:33 CET 2020


On 02/12/2020 14:38, Olivier Matz wrote:
> Fix compilation of examples/multi_process:
> 
>> examples/multi_process/client_server_mp/mp_server/main.c:68:4: error:
>> implicit declaration of function ‘rte_ether_format_addr’;
>> did you mean ‘ether_format_addr’? [-Werror=implicit-function-declaration]
>>     rte_ether_format_addr(err_address,
>>     ^~~~~~~~~~~~~~~~~~~~~
> 
> This failure happens after the backport of
> commit a7500412fc5c ("examples/multi_process: fix build on Ubuntu
> 20.04"), which uses a function that does not exist in this branch. The
> function was introduced by upstream commit 538da7a1cad2 ("net: add rte
> prefix to ether functions"), and is just a renaming of an existing
> function.
> 

Thanks Olivier. I had noticed this too and fixed locally. I will take
your patch as you sent it upstream first.

> Fixes: a7500412fc5c ("examples/multi_process: fix build on Ubuntu 20.04")
> 
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
> ---
>  examples/multi_process/client_server_mp/mp_server/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c
> index 1a5bf534ff..62abd62cf3 100644
> --- a/examples/multi_process/client_server_mp/mp_server/main.c
> +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> @@ -65,14 +65,14 @@ get_printable_mac_addr(uint16_t port)
>  
>  	if (unlikely(port >= RTE_MAX_ETHPORTS)) {
>  		if (err_address[0] == '\0')
> -			rte_ether_format_addr(err_address,
> +			ether_format_addr(err_address,
>  					sizeof(err_address), &null_mac);
>  		return err_address;
>  	}
>  	if (unlikely(addresses[port][0]=='\0')){
>  		struct ether_addr mac;
>  		rte_eth_macaddr_get(port, &mac);
> -		rte_ether_format_addr(addresses[port],
> +		ether_format_addr(addresses[port],
>  				sizeof(addresses[port]), &mac);
>  	}
>  	return addresses[port];
> 



More information about the stable mailing list