[dpdk-stable] patch 'app/testpmd: fix device mcast list error handling' has been queued to LTS release 18.11.7

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/b89ae651fb3122b2fef06fde2771902b2638cdbc

Thanks.

Kevin.

---
>From b89ae651fb3122b2fef06fde2771902b2638cdbc Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Wed, 4 Dec 2019 16:38:15 +0000
Subject: [PATCH] app/testpmd: fix device mcast list error handling

[ upstream commit c11562a1215aaff6651f9c59ef91ad0a53292571 ]

The multicast set list function now has a return value, which is checked
by the calling functions. A rollback occurs on detection of failure, to
realign local config with the device config.

The error print statement in the function had included the port_id and
mc_addr_nb values in the wrong order, these are now swapped.

Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses")

Signed-off-by: Ciara Power <ciara.power at intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test-pmd/config.c | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 6798f76974..6e9a2042c2 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3490,4 +3490,12 @@ mcast_addr_pool_extend(struct rte_port *port)
 }
 
+static void
+mcast_addr_pool_append(struct rte_port *port, struct ether_addr *mc_addr)
+{
+	if (mcast_addr_pool_extend(port) != 0)
+		return;
+	ether_addr_copy(mc_addr, &port->mc_addr_pool[port->mc_addr_nb - 1]);
+}
+
 static void
 mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx)
@@ -3508,5 +3516,5 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx)
 }
 
-static void
+static int
 eth_port_multicast_addr_list_set(portid_t port_id)
 {
@@ -3517,8 +3525,9 @@ eth_port_multicast_addr_list_set(portid_t port_id)
 	diag = rte_eth_dev_set_mc_addr_list(port_id, port->mc_addr_pool,
 					    port->mc_addr_nb);
-	if (diag == 0)
-		return;
-	printf("rte_eth_dev_set_mc_addr_list(port=%d, nb=%u) failed. diag=%d\n",
-	       port->mc_addr_nb, port_id, -diag);
+	if (diag < 0)
+		printf("rte_eth_dev_set_mc_addr_list(port=%d, nb=%u) failed. diag=%d\n",
+			port_id, port->mc_addr_nb, diag);
+
+	return diag;
 }
 
@@ -3545,8 +3554,8 @@ mcast_addr_add(portid_t port_id, struct ether_addr *mc_addr)
 	}
 
-	if (mcast_addr_pool_extend(port) != 0)
-		return;
-	ether_addr_copy(mc_addr, &port->mc_addr_pool[i]);
-	eth_port_multicast_addr_list_set(port_id);
+	mcast_addr_pool_append(port, mc_addr);
+	if (eth_port_multicast_addr_list_set(port_id) < 0)
+		/* Rollback on failure, remove the address from the pool */
+		mcast_addr_pool_remove(port, i);
 }
 
@@ -3575,5 +3584,7 @@ mcast_addr_remove(portid_t port_id, struct ether_addr *mc_addr)
 
 	mcast_addr_pool_remove(port, i);
-	eth_port_multicast_addr_list_set(port_id);
+	if (eth_port_multicast_addr_list_set(port_id) < 0)
+		/* Rollback on failure, add the address back into the pool */
+		mcast_addr_pool_append(port, mc_addr);
 }
 
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-07 15:08:18.203164255 +0000
+++ 0013-app-testpmd-fix-device-mcast-list-error-handling.patch	2020-02-07 15:08:17.501063122 +0000
@@ -1 +1 @@
-From c11562a1215aaff6651f9c59ef91ad0a53292571 Mon Sep 17 00:00:00 2001
+From b89ae651fb3122b2fef06fde2771902b2638cdbc Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c11562a1215aaff6651f9c59ef91ad0a53292571 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index 4e1c3cab59..9da1ffb034 100644
+index 6798f76974..6e9a2042c2 100644
@@ -26 +27 @@
-@@ -3708,4 +3708,12 @@ mcast_addr_pool_extend(struct rte_port *port)
+@@ -3490,4 +3490,12 @@ mcast_addr_pool_extend(struct rte_port *port)
@@ -30 +31 @@
-+mcast_addr_pool_append(struct rte_port *port, struct rte_ether_addr *mc_addr)
++mcast_addr_pool_append(struct rte_port *port, struct ether_addr *mc_addr)
@@ -34 +35 @@
-+	rte_ether_addr_copy(mc_addr, &port->mc_addr_pool[port->mc_addr_nb - 1]);
++	ether_addr_copy(mc_addr, &port->mc_addr_pool[port->mc_addr_nb - 1]);
@@ -39 +40 @@
-@@ -3726,5 +3734,5 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx)
+@@ -3508,5 +3516,5 @@ mcast_addr_pool_remove(struct rte_port *port, uint32_t addr_idx)
@@ -46 +47 @@
-@@ -3735,8 +3743,9 @@ eth_port_multicast_addr_list_set(portid_t port_id)
+@@ -3517,8 +3525,9 @@ eth_port_multicast_addr_list_set(portid_t port_id)
@@ -60 +61 @@
-@@ -3763,8 +3772,8 @@ mcast_addr_add(portid_t port_id, struct rte_ether_addr *mc_addr)
+@@ -3545,8 +3554,8 @@ mcast_addr_add(portid_t port_id, struct ether_addr *mc_addr)
@@ -65 +66 @@
--	rte_ether_addr_copy(mc_addr, &port->mc_addr_pool[i]);
+-	ether_addr_copy(mc_addr, &port->mc_addr_pool[i]);
@@ -73 +74 @@
-@@ -3793,5 +3802,7 @@ mcast_addr_remove(portid_t port_id, struct rte_ether_addr *mc_addr)
+@@ -3575,5 +3584,7 @@ mcast_addr_remove(portid_t port_id, struct ether_addr *mc_addr)