[dpdk-stable] patch 'app/testpmd: call cleanup on exit' has been queued to LTS release 18.11.7

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/ad2076ec30fb881f75e56cd81f556fc9e3b6ffee

Thanks.

Kevin.

---
>From ad2076ec30fb881f75e56cd81f556fc9e3b6ffee Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Tue, 7 Jan 2020 10:59:42 -0800
Subject: [PATCH] app/testpmd: call cleanup on exit

[ upstream commit 5e516c89830aacae67968490dbd8c542b9ffc430 ]

The rte_eal_cleanup code is not exercised by testpmd which
is the most used DPDK test tool. Add a call at end of program.

This helps exercise free and close paths which can
be checked with tools like valgrind.

Fixes: af75078fece3 ("first public release")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
---
 app/test-pmd/testpmd.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 98fe2f8f7d..31d559494d 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3297,4 +3297,9 @@ main(int argc, char** argv)
 	}
 
-	return 0;
+	ret = rte_eal_cleanup();
+	if (ret != 0)
+		rte_exit(EXIT_FAILURE,
+			 "EAL cleanup failed: %s\n", strerror(-ret));
+
+	return EXIT_SUCCESS;
 }
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-07 15:08:18.776037828 +0000
+++ 0024-app-testpmd-call-cleanup-on-exit.patch	2020-02-07 15:08:17.541062591 +0000
@@ -1 +1 @@
-From 5e516c89830aacae67968490dbd8c542b9ffc430 Mon Sep 17 00:00:00 2001
+From ad2076ec30fb881f75e56cd81f556fc9e3b6ffee Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5e516c89830aacae67968490dbd8c542b9ffc430 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index b374682236..2eec8afda1 100644
+index 98fe2f8f7d..31d559494d 100644
@@ -25 +26 @@
-@@ -3571,4 +3571,9 @@ main(int argc, char** argv)
+@@ -3297,4 +3297,9 @@ main(int argc, char** argv)