[dpdk-stable] patch 'net/netvsc: disable before changing RSS parameters' has been queued to stable release 19.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Feb 11 12:19:35 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 99682e1dc776a2c7ccb6965a4d6987bc5c75f8de Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Fri, 6 Dec 2019 15:52:48 -0800
Subject: [PATCH] net/netvsc: disable before changing RSS parameters

[ upstream commit b604e806327cd4945cc560722cf4c0b3518f0bc6 ]

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")

Signed-off-by: Donald Lee <donald_lee at trendmicro.com>
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Tested-by: Dexuan Cui <decui at microsoft.com>
Tested-by: Abhishek Marathe <abmarath at microsoft.com>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 5ef7a452cc..159116f7f6 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-11 11:17:40.177141149 +0000
+++ 0029-net-netvsc-disable-before-changing-RSS-parameters.patch	2020-02-11 11:17:38.340000225 +0000
@@ -1,13 +1,14 @@
-From b604e806327cd4945cc560722cf4c0b3518f0bc6 Mon Sep 17 00:00:00 2001
+From 99682e1dc776a2c7ccb6965a4d6987bc5c75f8de Mon Sep 17 00:00:00 2001
 From: Stephen Hemminger <stephen at networkplumber.org>
 Date: Fri, 6 Dec 2019 15:52:48 -0800
 Subject: [PATCH] net/netvsc: disable before changing RSS parameters
 
+[ upstream commit b604e806327cd4945cc560722cf4c0b3518f0bc6 ]
+
 In order to change RSS parameters, the host requires that RSS
 is disable first.
 
 Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
-Cc: stable at dpdk.org
 
 Signed-off-by: Donald Lee <donald_lee at trendmicro.com>
 Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the stable mailing list