[dpdk-stable] patch 'net/bnxt: remove redundant if statement' has been queued to stable release 19.11.1

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 79dd225dbacfe8c5e888c845c17ebc2120c5df8a Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Tue, 28 Jan 2020 12:59:18 +0530
Subject: [PATCH] net/bnxt: remove redundant if statement

[ upstream commit cc73dfd0418ed6ca14256677e639c35d82c1e051 ]

Since "eth_dev->data->dev_started" has been assigned to 0 at the
beginning of bnxt_dev_stop_op() routine, the code inside the if()
condition is redundant. Remove it.

Anyways "eth_dev->data->dev_link.link_status" will be set to 0 in
bnxt_dev_set_link_down_op() later in the routine.

Fixes: 316e412299fd ("net/bnxt: fix crash when closing")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 59400f3139..543ab2c7d4 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -933,10 +933,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
 	bnxt_cancel_fw_health_check(bp);
 
 	bp->flags &= ~BNXT_FLAG_INIT_DONE;
-	if (bp->eth_dev->data->dev_started) {
-		/* TBD: STOP HW queues DMA */
-		eth_dev->data->dev_link.link_status = 0;
-	}
 	bnxt_dev_set_link_down_op(eth_dev);
 
 	/* Wait for link to be reset and the async notification to process.
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-11 11:17:44.250724533 +0000
+++ 0162-net-bnxt-remove-redundant-if-statement.patch	2020-02-11 11:17:38.768008228 +0000
@@ -1,8 +1,10 @@
-From cc73dfd0418ed6ca14256677e639c35d82c1e051 Mon Sep 17 00:00:00 2001
+From 79dd225dbacfe8c5e888c845c17ebc2120c5df8a Mon Sep 17 00:00:00 2001
 From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
 Date: Tue, 28 Jan 2020 12:59:18 +0530
 Subject: [PATCH] net/bnxt: remove redundant if statement
 
+[ upstream commit cc73dfd0418ed6ca14256677e639c35d82c1e051 ]
+
 Since "eth_dev->data->dev_started" has been assigned to 0 at the
 beginning of bnxt_dev_stop_op() routine, the code inside the if()
 condition is redundant. Remove it.
@@ -11,7 +13,6 @@
 bnxt_dev_set_link_down_op() later in the routine.
 
 Fixes: 316e412299fd ("net/bnxt: fix crash when closing")
-Cc: stable at dpdk.org
 
 Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
 Signed-off-by: Somnath Kotur <somnath.kotur at broadcom.com>
@@ -21,10 +22,10 @@
  1 file changed, 4 deletions(-)
 
 diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
-index fc3f1a8db8..267a36148c 100644
+index 59400f3139..543ab2c7d4 100644
 --- a/drivers/net/bnxt/bnxt_ethdev.c
 +++ b/drivers/net/bnxt/bnxt_ethdev.c
-@@ -948,10 +948,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
+@@ -933,10 +933,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
  	bnxt_cancel_fw_health_check(bp);
  
  	bp->flags &= ~BNXT_FLAG_INIT_DONE;