[dpdk-stable] patch 'app/testpmd: fix uninitialized members of MPLS' has been queued to stable release 19.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Feb 11 12:21:57 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 6a5a82c6448f2c3009a632042fdcc5d4ed03d6fb Mon Sep 17 00:00:00 2001
From: Ori Kam <orika at mellanox.com>
Date: Thu, 30 Jan 2020 16:59:35 +0000
Subject: [PATCH] app/testpmd: fix uninitialized members of MPLS

[ upstream commit 56d5c1eedf22a1d384120466e6004faf9933d113 ]

Some of the members of the MPLS struct are not initialized.
This commit init the uninitialized members.

Coverity issue: 325735
Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation")

Signed-off-by: Ori Kam <orika at mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test-pmd/cmdline_flow.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 3cf05b5072..f059978730 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -4534,7 +4534,9 @@ parse_vc_action_mplsogre_decap(struct context *ctx, const struct token *token,
 	struct rte_flow_item_gre gre = {
 		.protocol = rte_cpu_to_be_16(ETHER_TYPE_MPLS_UNICAST),
 	};
-	struct rte_flow_item_mpls mpls;
+	struct rte_flow_item_mpls mpls = {
+		.ttl = 0,
+	};
 	uint8_t *header;
 	int ret;
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-11 11:17:44.527794713 +0000
+++ 0171-app-testpmd-fix-uninitialized-members-of-MPLS.patch	2020-02-11 11:17:38.808008976 +0000
@@ -1,14 +1,15 @@
-From 56d5c1eedf22a1d384120466e6004faf9933d113 Mon Sep 17 00:00:00 2001
+From 6a5a82c6448f2c3009a632042fdcc5d4ed03d6fb Mon Sep 17 00:00:00 2001
 From: Ori Kam <orika at mellanox.com>
 Date: Thu, 30 Jan 2020 16:59:35 +0000
 Subject: [PATCH] app/testpmd: fix uninitialized members of MPLS
 
+[ upstream commit 56d5c1eedf22a1d384120466e6004faf9933d113 ]
+
 Some of the members of the MPLS struct are not initialized.
 This commit init the uninitialized members.
 
 Coverity issue: 325735
 Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ori Kam <orika at mellanox.com>
 Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
@@ -17,10 +18,10 @@
  1 file changed, 3 insertions(+), 1 deletion(-)
 
 diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
-index e99e24c29f..c2cc4c57b8 100644
+index 3cf05b5072..f059978730 100644
 --- a/app/test-pmd/cmdline_flow.c
 +++ b/app/test-pmd/cmdline_flow.c
-@@ -4576,7 +4576,9 @@ parse_vc_action_mplsogre_encap(struct context *ctx, const struct token *token,
+@@ -4534,7 +4534,9 @@ parse_vc_action_mplsogre_decap(struct context *ctx, const struct token *token,
  	struct rte_flow_item_gre gre = {
  		.protocol = rte_cpu_to_be_16(ETHER_TYPE_MPLS_UNICAST),
  	};


More information about the stable mailing list