[dpdk-stable] patch 'mempool: fix anonymous populate' has been queued to LTS release 18.11.7

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/20/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/bb443e3fa89409c154cfbd738fcc2ea3b50f858c

Thanks.

Kevin.

---
>From bb443e3fa89409c154cfbd738fcc2ea3b50f858c Mon Sep 17 00:00:00 2001
From: Olivier Matz <olivier.matz at 6wind.com>
Date: Fri, 17 Jan 2020 15:34:29 +0100
Subject: [PATCH] mempool: fix anonymous populate

[ upstream commit f159c61c35ebc6ff18d2c6c2cb07c177935a96e3 ]

The documentation says that a negative errno is returned on error, but
in most places that's not the case.

Fix the documentation and the exceptions in code. The second one
(return from populate_virt) also fixes a memory leak.

Note that testpmd was using the function correctly.

Fixes: aa10457eb4c2 ("mempool: make mempool populate and free api public")
Fixes: 6780f72fb82f ("mempool: populate with anonymous memory")
Fixes: 66e7ba0bad4c ("mempool: ensure mempool is initialized before populating")

Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
---
 lib/librte_mempool/rte_mempool.c | 10 +++++++---
 lib/librte_mempool/rte_mempool.h |  4 ++--
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 99530a5955..9fc038b745 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -679,6 +679,8 @@ rte_mempool_populate_anon(struct rte_mempool *mp)
 
 	ret = mempool_ops_alloc_once(mp);
-	if (ret != 0)
-		return ret;
+	if (ret < 0) {
+		rte_errno = -ret;
+		return 0;
+	}
 
 	size = get_anon_size(mp);
@@ -704,6 +706,8 @@ rte_mempool_populate_anon(struct rte_mempool *mp)
 	ret = rte_mempool_populate_virt(mp, addr, size, getpagesize(),
 		rte_mempool_memchunk_anon_free, addr);
-	if (ret == 0)
+	if (ret < 0) {
+		rte_errno = -ret;
 		goto fail;
+	}
 
 	return mp->populated_size;
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index fe2f33352c..a22cef49e0 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -1088,6 +1088,6 @@ int rte_mempool_populate_default(struct rte_mempool *mp);
  * @return
  *   The number of objects added on success.
- *   On error, the chunk is not added in the memory list of the
- *   mempool and a negative errno is returned.
+ *   On error, 0 is returned, rte_errno is set, and the chunk is not added in
+ *   the memory list of the mempool.
  */
 int rte_mempool_populate_anon(struct rte_mempool *mp);
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-14 17:02:37.705900070 +0000
+++ 0012-mempool-fix-anonymous-populate.patch	2020-02-14 17:02:36.939408189 +0000
@@ -1 +1 @@
-From f159c61c35ebc6ff18d2c6c2cb07c177935a96e3 Mon Sep 17 00:00:00 2001
+From bb443e3fa89409c154cfbd738fcc2ea3b50f858c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f159c61c35ebc6ff18d2c6c2cb07c177935a96e3 ]
+
@@ -17 +18,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
-index 78d8eb941e..f8d453d21f 100644
+index 99530a5955..9fc038b745 100644
@@ -29 +30 @@
-@@ -646,6 +646,8 @@ rte_mempool_populate_anon(struct rte_mempool *mp)
+@@ -679,6 +679,8 @@ rte_mempool_populate_anon(struct rte_mempool *mp)
@@ -40 +41 @@
-@@ -671,6 +673,8 @@ rte_mempool_populate_anon(struct rte_mempool *mp)
+@@ -704,6 +706,8 @@ rte_mempool_populate_anon(struct rte_mempool *mp)
@@ -51 +52 @@
-index f81152af96..0a1dc6059f 100644
+index fe2f33352c..a22cef49e0 100644
@@ -54 +55 @@
-@@ -1168,6 +1168,6 @@ int rte_mempool_populate_default(struct rte_mempool *mp);
+@@ -1088,6 +1088,6 @@ int rte_mempool_populate_default(struct rte_mempool *mp);