[dpdk-stable] patch 'examples/ethtool: fix unchecked return value' has been queued to stable release 19.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Feb 17 18:44:54 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From ae4b345b73efc36b7f587104a7b5c09bbe395cc4 Mon Sep 17 00:00:00 2001
From: Gargi Sau <gargi.sau at intel.com>
Date: Mon, 9 Dec 2019 06:37:56 +0000
Subject: [PATCH] examples/ethtool: fix unchecked return value

[ upstream commit 899f6de24bb6504d56369aef5f55bb370d58784d ]

This checks the return value from the function
rte_eth_dev_set_vlan_offload.

Coverity issue: 350358
Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")

Signed-off-by: Gargi Sau <gargi.sau at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 examples/ethtool/lib/rte_ethtool.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
index 667d7eaf27..db8150efd5 100644
--- a/examples/ethtool/lib/rte_ethtool.c
+++ b/examples/ethtool/lib/rte_ethtool.c
@@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
 	}
 
 	/* Enable Rx vlan filter, VF unspport status is discard */
-	rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
+	ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
+	if (ret != 0)
+		return ret;
 
 	return 0;
 }
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-17 17:00:15.430059538 +0000
+++ 0002-examples-ethtool-fix-unchecked-return-value.patch	2020-02-17 17:00:15.263949832 +0000
@@ -1,14 +1,15 @@
-From 899f6de24bb6504d56369aef5f55bb370d58784d Mon Sep 17 00:00:00 2001
+From ae4b345b73efc36b7f587104a7b5c09bbe395cc4 Mon Sep 17 00:00:00 2001
 From: Gargi Sau <gargi.sau at intel.com>
 Date: Mon, 9 Dec 2019 06:37:56 +0000
 Subject: [PATCH] examples/ethtool: fix unchecked return value
 
+[ upstream commit 899f6de24bb6504d56369aef5f55bb370d58784d ]
+
 This checks the return value from the function
 rte_eth_dev_set_vlan_offload.
 
 Coverity issue: 350358
 Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
-Cc: stable at dpdk.org
 
 Signed-off-by: Gargi Sau <gargi.sau at intel.com>
 Acked-by: Bruce Richardson <bruce.richardson at intel.com>


More information about the stable mailing list