[dpdk-stable] patch 'examples/ioat: fix failure check for ioat dequeue' has been queued to stable release 19.11.1

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/19/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From b406a83fb4fa4e8223530226e39365094f515508 Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Tue, 4 Feb 2020 16:00:06 +0000
Subject: [PATCH] examples/ioat: fix failure check for ioat dequeue

[ upstream commit 579fb0b2c33a0946f37d120c4e3837a0a3817a7d ]

The nb_dq return value from the ioat dequeue is negative in failure
cases, however the variable was an unsigned int, causing the condition
where nb_dq <= 0 to never be true. This is now cast to a signed int,
which will successfully reflect the -1 value to be used in this
conditional check.

Coverity issue: 350342
Coverity issue: 350349
Fixes: 92c981637ffc ("examples/ioat: handle failure case for ioat dequeue")

Signed-off-by: Ciara Power <ciara.power at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 examples/ioat/ioatfwd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c
index b39a098ec0..8a6076828d 100644
--- a/examples/ioat/ioatfwd.c
+++ b/examples/ioat/ioatfwd.c
@@ -460,7 +460,7 @@ ioat_tx_port(struct rxtx_port_config *tx_config)
 				MAX_PKT_BURST, NULL);
 		}
 
-		if (nb_dq <= 0)
+		if ((int32_t) nb_dq <= 0)
 			return;
 
 		if (copy_mode == COPY_MODE_IOAT_NUM)
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-17 17:00:15.478858510 +0000
+++ 0004-examples-ioat-fix-failure-check-for-ioat-dequeue.patch	2020-02-17 17:00:15.267949888 +0000
@@ -1,8 +1,10 @@
-From 579fb0b2c33a0946f37d120c4e3837a0a3817a7d Mon Sep 17 00:00:00 2001
+From b406a83fb4fa4e8223530226e39365094f515508 Mon Sep 17 00:00:00 2001
 From: Ciara Power <ciara.power at intel.com>
 Date: Tue, 4 Feb 2020 16:00:06 +0000
 Subject: [PATCH] examples/ioat: fix failure check for ioat dequeue
 
+[ upstream commit 579fb0b2c33a0946f37d120c4e3837a0a3817a7d ]
+
 The nb_dq return value from the ioat dequeue is negative in failure
 cases, however the variable was an unsigned int, causing the condition
 where nb_dq <= 0 to never be true. This is now cast to a signed int,
@@ -12,7 +14,6 @@
 Coverity issue: 350342
 Coverity issue: 350349
 Fixes: 92c981637ffc ("examples/ioat: handle failure case for ioat dequeue")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ciara Power <ciara.power at intel.com>
 Acked-by: Bruce Richardson <bruce.richardson at intel.com>