[dpdk-stable] patch 'lib: fix unnecessary double negation' has been queued to LTS release 18.11.7

Kevin Traynor ktraynor at redhat.com
Wed Feb 19 16:55:53 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/25/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/368b63ca65b313dde4e85d85ea5a926914c4b207

Thanks.

Kevin.

---
>From 368b63ca65b313dde4e85d85ea5a926914c4b207 Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Fri, 14 Feb 2020 16:17:25 +0000
Subject: [PATCH] lib: fix unnecessary double negation

[ upstream commit f42c9ac5b6b5fabd3c6bb124914af6704445e853 ]

An equality expression already returns either 0 or 1.
There is no need to use double negation for these cases.

Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure")
Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names")

Signed-off-by: Ciara Power <ciara.power at intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
Acked-by: Olivier Matz <olivier.matz at 6wind.com>
---
 lib/librte_mbuf/rte_mbuf.h       | 2 +-
 lib/librte_mempool/rte_mempool.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 8eab5a836b..56406f15c9 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -2093,5 +2093,5 @@ static inline int rte_pktmbuf_is_contiguous(const struct rte_mbuf *m)
 {
 	__rte_mbuf_sanity_check(m, 1);
-	return !!(m->nb_segs == 1);
+	return m->nb_segs == 1;
 }
 
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index a22cef49e0..217fd34b57 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -1574,5 +1574,5 @@ static inline int
 rte_mempool_full(const struct rte_mempool *mp)
 {
-	return !!(rte_mempool_avail_count(mp) == mp->size);
+	return rte_mempool_avail_count(mp) == mp->size;
 }
 
@@ -1593,5 +1593,5 @@ static inline int
 rte_mempool_empty(const struct rte_mempool *mp)
 {
-	return !!(rte_mempool_avail_count(mp) == 0);
+	return rte_mempool_avail_count(mp) == 0;
 }
 
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-19 15:43:50.145205864 +0000
+++ 0008-lib-fix-unnecessary-double-negation.patch	2020-02-19 15:43:49.728142053 +0000
@@ -1 +1 @@
-From f42c9ac5b6b5fabd3c6bb124914af6704445e853 Mon Sep 17 00:00:00 2001
+From 368b63ca65b313dde4e85d85ea5a926914c4b207 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f42c9ac5b6b5fabd3c6bb124914af6704445e853 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 59023893a5..34679e0920 100644
+index 8eab5a836b..56406f15c9 100644
@@ -25 +26 @@
-@@ -1700,5 +1700,5 @@ static inline int rte_pktmbuf_is_contiguous(const struct rte_mbuf *m)
+@@ -2093,5 +2093,5 @@ static inline int rte_pktmbuf_is_contiguous(const struct rte_mbuf *m)
@@ -33 +34 @@
-index a2c92727a6..c90cf31467 100644
+index a22cef49e0..217fd34b57 100644
@@ -36 +37 @@
-@@ -1655,5 +1655,5 @@ static inline int
+@@ -1574,5 +1574,5 @@ static inline int
@@ -43 +44 @@
-@@ -1674,5 +1674,5 @@ static inline int
+@@ -1593,5 +1593,5 @@ static inline int



More information about the stable mailing list