[dpdk-stable] patch 'usertools: fix syntax warning in python 3.8' has been queued to LTS release 18.11.7

Kevin Traynor ktraynor at redhat.com
Wed Feb 19 16:56:06 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/25/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/f9b34162ff487d8c3c59a246b785c9efc4cc987f

Thanks.

Kevin.

---
>From f9b34162ff487d8c3c59a246b785c9efc4cc987f Mon Sep 17 00:00:00 2001
From: Thomas Faivre <thomas.faivre at 6wind.com>
Date: Wed, 12 Feb 2020 13:31:56 +0100
Subject: [PATCH] usertools: fix syntax warning in python 3.8

[ upstream commit e1766e7b0c9b4ad30b330677f2376a05b3b46f0c ]

Silent the following warning when running script with python 3.8:

> /usr/bin/dpdk-pmdinfo:542: SyntaxWarning: "is" with a literal.
> Did you mean "=="?
>   if (autoload_path is None or autoload_path is ""):

As autoload_path can only be None or a string, directly check its bool
value.

Fixes: c67c9a5c646a ("tools: query binaries for HW and other support information")

Signed-off-by: Thomas Faivre <thomas.faivre at 6wind.com>
---
 usertools/dpdk-pmdinfo.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py
index 069a3bf124..9d5c6369a0 100755
--- a/usertools/dpdk-pmdinfo.py
+++ b/usertools/dpdk-pmdinfo.py
@@ -540,5 +540,5 @@ def scan_for_autoload_pmds(dpdk_path):
 
     (autoload_path, scannedfile) = readelf.search_for_autoload_path()
-    if (autoload_path is None or autoload_path is ""):
+    if not autoload_path:
         if (raw_output is False):
             print("No autoload path configured in %s" % dpdk_path)
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-19 15:43:50.817113294 +0000
+++ 0021-usertools-fix-syntax-warning-in-python-3.8.patch	2020-02-19 15:43:49.766141283 +0000
@@ -1 +1 @@
-From e1766e7b0c9b4ad30b330677f2376a05b3b46f0c Mon Sep 17 00:00:00 2001
+From f9b34162ff487d8c3c59a246b785c9efc4cc987f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e1766e7b0c9b4ad30b330677f2376a05b3b46f0c ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org



More information about the stable mailing list