[dpdk-stable] patch 'net/sfc: fix log format specifiers' has been queued to LTS release 18.11.7

Kevin Traynor ktraynor at redhat.com
Thu Feb 27 18:38:02 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/c3355d30cafe3494b8a3b437b4261572c041be7b

Thanks.

Kevin.

---
>From c3355d30cafe3494b8a3b437b4261572c041be7b Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at intel.com>
Date: Wed, 19 Feb 2020 14:04:57 +0000
Subject: [PATCH] net/sfc: fix log format specifiers

[ upstream commit 6b9a30d9e93da9f6c167249ba4d79fd5470b7e17 ]

The format specifier for the 'size_t' format should be '%z'.

Also this fix enables compiling PMD for 32bit architecture.

Fixes: ba641f207642 ("net/sfc: add init on attach")
Fixes: 82faef507608 ("net/sfc: set RSS key and hash types config")
Fixes: 7803554a9e38 ("net/sfc: process RSS settings on Rx configure step")

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>
---
 drivers/net/sfc/sfc.c        | 2 +-
 drivers/net/sfc/sfc_ethdev.c | 2 +-
 drivers/net/sfc/sfc_rx.c     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c
index 0d7311d687..d056d12164 100644
--- a/drivers/net/sfc/sfc.c
+++ b/drivers/net/sfc/sfc.c
@@ -31,5 +31,5 @@ sfc_dma_alloc(const struct sfc_adapter *sa, const char *name, uint16_t id,
 	const struct rte_memzone *mz;
 
-	sfc_log_init(sa, "name=%s id=%u len=%lu socket_id=%d",
+	sfc_log_init(sa, "name=%s id=%u len=%zu socket_id=%d",
 		     name, id, len, socket_id);
 
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 8c7d224300..fa38417b7c 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -1461,5 +1461,5 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
 	if ((rss_conf->rss_key != NULL) &&
 	    (rss_conf->rss_key_len != sizeof(rss->key))) {
-		sfc_err(sa, "RSS key size is wrong (should be %lu)",
+		sfc_err(sa, "RSS key size is wrong (should be %zu)",
 			sizeof(rss->key));
 		return -EINVAL;
diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c
index 630f6b455a..960ab62c19 100644
--- a/drivers/net/sfc/sfc_rx.c
+++ b/drivers/net/sfc/sfc_rx.c
@@ -1323,5 +1323,5 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa,
 	if (conf->rss_key != NULL) {
 		if (conf->rss_key_len != sizeof(rss->key)) {
-			sfc_err(sa, "RSS key size is wrong (should be %lu)",
+			sfc_err(sa, "RSS key size is wrong (should be %zu)",
 				sizeof(rss->key));
 			return EINVAL;
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-27 17:26:24.325565665 +0000
+++ 0011-net-sfc-fix-log-format-specifiers.patch	2020-02-27 17:26:23.658830932 +0000
@@ -1 +1 @@
-From 6b9a30d9e93da9f6c167249ba4d79fd5470b7e17 Mon Sep 17 00:00:00 2001
+From c3355d30cafe3494b8a3b437b4261572c041be7b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6b9a30d9e93da9f6c167249ba4d79fd5470b7e17 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 141c767f09..c6b514ac2f 100644
+index 0d7311d687..d056d12164 100644
@@ -35 +36 @@
-index 454b8956a2..098038fbc0 100644
+index 8c7d224300..fa38417b7c 100644
@@ -38 +39 @@
-@@ -1521,5 +1521,5 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
+@@ -1461,5 +1461,5 @@ sfc_dev_rss_hash_update(struct rte_eth_dev *dev,
@@ -46 +47 @@
-index 74218296cd..7afd2c8b33 100644
+index 630f6b455a..960ab62c19 100644
@@ -49 +50 @@
-@@ -1404,5 +1404,5 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa,
+@@ -1323,5 +1323,5 @@ sfc_rx_process_adv_conf_rss(struct sfc_adapter *sa,



More information about the stable mailing list