[dpdk-stable] patch 'app/testpmd: fix identifier size for port attach' has been queued to LTS release 18.11.7

Kevin Traynor ktraynor at redhat.com
Thu Feb 27 18:38:05 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/02/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/7c18f03d0856719b3d80cc81812b7af28b5f6b66

Thanks.

Kevin.

---
>From 7c18f03d0856719b3d80cc81812b7af28b5f6b66 Mon Sep 17 00:00:00 2001
From: Wisam Jaddo <wisamm at mellanox.com>
Date: Wed, 19 Feb 2020 18:47:30 +0200
Subject: [PATCH] app/testpmd: fix identifier size for port attach

[ upstream commit f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 ]

Identifier for new port may contain white list options,
and white list options will not fit into 128 from STR_TOKEN_SIZE,
instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
better and more options

Fixes: edab33b1c01d ("app/testpmd: support port hotplug")

Signed-off-by: Wisam Jaddo <wisamm at mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
---
 app/test-pmd/cmdline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 27ce5d1880..26295130c5 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1411,5 +1411,5 @@ struct cmd_operate_attach_port_result {
 	cmdline_fixed_string_t port;
 	cmdline_fixed_string_t keyword;
-	cmdline_fixed_string_t identifier;
+	cmdline_multi_string_t identifier;
 };
 
@@ -1434,5 +1434,5 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
 cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
 	TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
-			identifier, NULL);
+			identifier, TOKEN_STRING_MULTI);
 
 cmdline_parse_inst_t cmd_operate_attach_port = {
-- 
2.21.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-02-27 17:26:24.532231997 +0000
+++ 0014-app-testpmd-fix-identifier-size-for-port-attach.patch	2020-02-27 17:26:23.685830371 +0000
@@ -1 +1 @@
-From f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 Mon Sep 17 00:00:00 2001
+From 7c18f03d0856719b3d80cc81812b7af28b5f6b66 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 38b6d804c6..a037a55c6a 100644
+index 27ce5d1880..26295130c5 100644
@@ -24 +25 @@
-@@ -1447,5 +1447,5 @@ struct cmd_operate_attach_port_result {
+@@ -1411,5 +1411,5 @@ struct cmd_operate_attach_port_result {
@@ -31 +32 @@
-@@ -1470,5 +1470,5 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
+@@ -1434,5 +1434,5 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =



More information about the stable mailing list