[dpdk-stable] [dpdk-dev] [PATCH v3] net/vhost: fix return value of vhost creates not checked
Yunjian Wang
wangyunjian at huawei.com
Tue Jan 7 04:25:48 CET 2020
The function eth_dev_vhost_create() could return errors,
the return value need to be checked.
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: stable at dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
---
v3:
* Add newline at the end of the error message
v2:
* Change function eth_dev_vhost_create return 0 on success
---
drivers/net/vhost/rte_eth_vhost.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 46f01a7..a635889 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -1302,7 +1302,7 @@ struct vhost_xstats_name_off {
}
rte_eth_dev_probing_finish(eth_dev);
- return data->port_id;
+ return 0;
error:
if (internal) {
@@ -1455,8 +1455,10 @@ struct vhost_xstats_name_off {
if (dev->device.numa_node == SOCKET_ID_ANY)
dev->device.numa_node = rte_socket_id();
- eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node,
- flags, disable_flags);
+ ret = eth_dev_vhost_create(dev, iface_name, queues,
+ dev->device.numa_node, flags, disable_flags);
+ if (ret == -1)
+ VHOST_LOG(ERR, "Failed to create %s\n", name);
out_free:
rte_kvargs_free(kvlist);
--
1.8.3.1
More information about the stable
mailing list