[dpdk-stable] [dpdk-dev] [PATCH v2] mempool: fix mempool obj alignment for non x86

Stephen Hemminger stephen at networkplumber.org
Sat Jan 11 18:41:47 CET 2020


On Sat, 11 Jan 2020 19:04:10 +0530
<jerinj at marvell.com> wrote:

> -#define MEMPOOL_F_NO_SPREAD      0x0001 /**< Do not spread among memory channels. */
> +#define MEMPOOL_F_NO_SPREAD      0x0001
> +/**< Do not spread among memory channels. It is a hint to the library,
> + * library honor this hint only when, if it is required by the
> + * (micro) architecture.
> + */

That text is awkward for me to read.
There maybe other reasons in future for mempool to ignore the flag.

I prefer the minor change original comment as:
> -#define MEMPOOL_F_NO_SPREAD      0x0001 /**< Spreading among memory channels not required. */


More information about the stable mailing list