[dpdk-stable] [PATCH] test/compress: replace test vector

Thomas Monjalon thomas at monjalon.net
Fri Jan 17 22:51:30 CET 2020


15/01/2020 16:54, Akhil Goyal:
> > >
> > > This patch replaces existing test vector with a new
> > > one containing C code to fix license issue.
> > >
> > > Signed-off-by: Artur Trybula <arturx.trybula at intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe at intel.com>
> Applied to dpdk-next-crypto

This is a terrible idea.
Adding C code in a C project as text, and worst, its own code,
will make grep matching on fake text.

Why do you need so much text to compress?
Why not just opening our own code files as text?

Why stable at dpdk.org is Cc'ed in this email?
What is the license issue?
Should it be backported? If yes, the stable tag is missing.

I drop this patch from -rc1.




More information about the stable mailing list