[dpdk-stable] [dpdk-dev] [PATCH v2] lib/table: fix cache alignment issue

Zhou, JunX W junx.w.zhou at intel.com
Thu Jul 2 10:06:35 CEST 2020


Tested-by: junx.w.zhou at intel.com

-----Original Message-----
From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ting Xu
Sent: Wednesday, June 17, 2020 1:44 PM
To: dev at dpdk.org
Cc: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; stable at dpdk.org
Subject: [dpdk-dev] [PATCH v2] lib/table: fix cache alignment issue

When create softnic hash table with 16 keys, it failed on 32bit environment because of the structure rte_bucket_4_16 alignment issue. Add __rte_cache_aligned to ensure correct cache align.

Fixes: 8aa327214c ("table: hash")
Cc: stable at dpdk.org

Signed-off-by: Ting Xu <ting.xu at intel.com>

---
v1->v2: Correct patch time
---
 lib/librte_table/rte_table_hash_key16.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_hash_key16.c
index 2cca1c924..5e1665c15 100644
--- a/lib/librte_table/rte_table_hash_key16.c
+++ b/lib/librte_table/rte_table_hash_key16.c
@@ -44,7 +44,7 @@ struct rte_bucket_4_16 {
 	uint64_t key[4][2];
 
 	/* Cache line 2 */
-	uint8_t data[0];
+	uint8_t data[0] __rte_cache_aligned;
 };
 
 struct rte_table_hash {
--
2.17.1



More information about the stable mailing list