[dpdk-stable] [PATCH 1/2] eal: remove redundant code
Honnappa Nagarahalli
Honnappa.Nagarahalli at arm.com
Wed Jul 8 07:14:46 CEST 2020
<snip>
> Subject: [PATCH 1/2] eal: remove redundant code
>
> The event status has been cleaned up by the CAS operation when we free
> the event data, so there is no need to set it to invalid after that.
>
> Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt")
> Cc: shahafs at mellanox.com
> Cc: stable at dpdk.org
This is not a bug fix. I think it is not worth backporting, suggest removing this.
>
> Signed-off-by: Phil Yang <phil.yang at arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
Otherwise
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> ---
> lib/librte_eal/linux/eal_interrupts.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal_interrupts.c
> b/lib/librte_eal/linux/eal_interrupts.c
> index 16e7a7d..2f369dc 100644
> --- a/lib/librte_eal/linux/eal_interrupts.c
> +++ b/lib/librte_eal/linux/eal_interrupts.c
> @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle
> *intr_handle)
> if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) {
> /* force free if the entry valid */
> eal_epoll_data_safe_free(rev);
> - rev->status = RTE_EPOLL_INVALID;
> }
> }
> }
> --
> 2.7.4
More information about the stable
mailing list