[dpdk-stable] [dpdk-dev] [PATCH] net: fix checksum on big endian CPUs

[Thomas Monjalon]

10/07/2020 14:37, Olivier Matz:
> On Fri, Jul 10, 2020 at 02:20:08PM +0200, Morten Brørup wrote:
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Hongzhi Guo
> > > Sent: Friday, July 10, 2020 1:43 PM
> > > 
> > > With current code, the checksum of odd-length buffers is wrong on
> > > big endian CPUs: the last byte is not properly summed to the
> > > accumulator.
> > > 
> > > Fix this by left-shifting the remaining byte by 8. For instance,
> > > if the last byte is 0x42, we should add 0x4200 to the accumulator
> > > on big endian CPUs.
> > > 
> > > This change is similar to what is suggested in Errata 3133 of
> > > RFC 1071.
> > > 
> > > Fixes: 6006818cfb26("net: new checksum functions")
> > > Cc: stable at dpdk.org
> > > 
> > > Signed-off-by: Hongzhi Guo <guohongzhi1 at huawei.com>
> > 
> > Reviewed-by: Morten Brørup <mb at smartsharesystems.com>
> 
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>

Applied, thank you Hongzhi Guo, we want more patches like this :-)