[dpdk-stable] patch 'net/mvpp2: fix non-EAL thread support' has been queued to LTS release 18.11.10

Kevin Traynor ktraynor at redhat.com
Fri Jul 17 18:32:01 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/23/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/978be5abe162b5ebe1be3eb0d74fdfeedbbaa9bc

Thanks.

Kevin.

---
>From 978be5abe162b5ebe1be3eb0d74fdfeedbbaa9bc Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Tue, 16 Jun 2020 11:47:00 +0200
Subject: [PATCH] net/mvpp2: fix non-EAL thread support

[ upstream commit b52d25ae4b1bbe9adba0d9276b7771ec27e3d151 ]

Caught by code inspection, for a non-EAL thread identified with
rte_lcore_id() == LCORE_ID_ANY, the code currently arbitrarily uses
lcore 0 while there is no guarantee this lcore is used.

Fixes: 3588aaa68eab ("net/mrvl: fix HIF objects allocation")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Liron Himi <lironh at marvell.com>
---
 drivers/net/mvpp2/mrvl_ethdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index ab4c14e513..97842fba76 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -813,5 +813,5 @@ mrvl_flush_bpool(struct rte_eth_dev *dev)
 
 	if (core_id == LCORE_ID_ANY)
-		core_id = 0;
+		core_id = rte_get_master_lcore();
 
 	hif = mrvl_get_hif(priv, core_id);
@@ -1565,5 +1565,5 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num)
 	core_id = rte_lcore_id();
 	if (core_id == LCORE_ID_ANY)
-		core_id = 0;
+		core_id = rte_get_master_lcore();
 
 	hif = mrvl_get_hif(rxq->priv, core_id);
@@ -1715,5 +1715,5 @@ mrvl_rx_queue_release(void *rxq)
 
 	if (core_id == LCORE_ID_ANY)
-		core_id = 0;
+		core_id = rte_get_master_lcore();
 
 	if (!q)
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-07-17 17:17:00.725364479 +0100
+++ 0013-net-mvpp2-fix-non-EAL-thread-support.patch	2020-07-17 17:16:59.985771318 +0100
@@ -1 +1 @@
-From b52d25ae4b1bbe9adba0d9276b7771ec27e3d151 Mon Sep 17 00:00:00 2001
+From 978be5abe162b5ebe1be3eb0d74fdfeedbbaa9bc Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b52d25ae4b1bbe9adba0d9276b7771ec27e3d151 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index b98b1fd667..9037274327 100644
+index ab4c14e513..97842fba76 100644
@@ -23 +24 @@
-@@ -817,5 +817,5 @@ mrvl_flush_bpool(struct rte_eth_dev *dev)
+@@ -813,5 +813,5 @@ mrvl_flush_bpool(struct rte_eth_dev *dev)
@@ -30 +31 @@
-@@ -1621,5 +1621,5 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num)
+@@ -1565,5 +1565,5 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num)
@@ -37 +38 @@
-@@ -1771,5 +1771,5 @@ mrvl_rx_queue_release(void *rxq)
+@@ -1715,5 +1715,5 @@ mrvl_rx_queue_release(void *rxq)



More information about the stable mailing list