[dpdk-stable] [PATCH] net/ice: fix default RSS key configuration

Zhang, Qi Z qi.z.zhang at intel.com
Thu Jul 23 12:25:35 CEST 2020



> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, July 22, 2020 1:26 PM
> To: Wang, Xiao W <xiao.w.wang at intel.com>
> Cc: dev at dpdk.org; Yang, Qiming <qiming.yang at intel.com>; Yao, Lei A
> <lei.a.yao at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; stable at dpdk.org
> Subject: RE: [PATCH] net/ice: fix default RSS key configuration
> 
> 
> 
> > -----Original Message-----
> > From: Wang, Xiao W <xiao.w.wang at intel.com>
> > Sent: Tuesday, July 21, 2020 5:03 PM
> > To: Zhang, Qi Z <qi.z.zhang at intel.com>
> > Cc: dev at dpdk.org; Yang, Qiming <qiming.yang at intel.com>; Yao, Lei A
> > <lei.a.yao at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Wang,
> > Xiao W <xiao.w.wang at intel.com>; stable at dpdk.org
> > Subject: [PATCH] net/ice: fix default RSS key configuration
> >
> > There's chance that rte_rand() doesn't provision suitable values for
> > RSS hash, an extreme example could be a key with a lot of 0s in it.
> >
> > This patch adds a default RSS key which has been used in ixgbe driver
> > and fm10k driver.
> >
> > Fixes: 50370662b727 ("net/ice: support device and queue ops")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang at intel.com>
> 
> Applied to dpdk-next-net-intel.

After some internal discussion, we decide to keep the random key as default, and user can use rte_eth_dev_rss_hash_update to update a new key.
So the patch has been removed from dpdk-next-net-intel.


> 
> Thanks
> Qi


More information about the stable mailing list