[dpdk-stable] patch 'app/testpmd: fix memory leak on error path' has been queued to stable release 19.11.4

luca.boccassi at gmail.com luca.boccassi at gmail.com
Fri Jul 24 13:57:29 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/26/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 77b9982fa2eba4652be86d61c5662958a2902f0c Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Mon, 25 May 2020 09:46:23 +0800
Subject: [PATCH] app/testpmd: fix memory leak on error path

[ upstream commit eb577e575d160eae08bcd9b7acf8a9d8fe795f89 ]

This patch fixes the resource leak issue.

Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test-pmd/cmdline_mtr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index ab5c8642d..045c2e28d 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -1262,6 +1262,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,
 	ret = rte_mtr_policer_actions_update(port_id, mtr_id,
 		action_mask, actions, &error);
 	if (ret != 0) {
+		free(actions);
 		print_err_msg(&error);
 		return;
 	}
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-07-24 12:53:49.024237896 +0100
+++ 0011-app-testpmd-fix-memory-leak-on-error-path.patch	2020-07-24 12:53:48.159004075 +0100
@@ -1,12 +1,13 @@
-From eb577e575d160eae08bcd9b7acf8a9d8fe795f89 Mon Sep 17 00:00:00 2001
+From 77b9982fa2eba4652be86d61c5662958a2902f0c Mon Sep 17 00:00:00 2001
 From: Yunjian Wang <wangyunjian at huawei.com>
 Date: Mon, 25 May 2020 09:46:23 +0800
 Subject: [PATCH] app/testpmd: fix memory leak on error path
 
+[ upstream commit eb577e575d160eae08bcd9b7acf8a9d8fe795f89 ]
+
 This patch fixes the resource leak issue.
 
 Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
-Cc: stable at dpdk.org
 
 Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
 Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
@@ -15,7 +16,7 @@
  1 file changed, 1 insertion(+)
 
 diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
-index caa7e9864..ee16244de 100644
+index ab5c8642d..045c2e28d 100644
 --- a/app/test-pmd/cmdline_mtr.c
 +++ b/app/test-pmd/cmdline_mtr.c
 @@ -1262,6 +1262,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,


More information about the stable mailing list