[dpdk-stable] patch 'net: fix IPv4 checksum' has been queued to stable release 19.11.4

luca.boccassi at gmail.com luca.boccassi at gmail.com
Fri Jul 24 13:58:03 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/26/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 430b02f1a047df789916fe0bcd980a3048d2c364 Mon Sep 17 00:00:00 2001
From: Hongzhi Guo <guohongzhi1 at huawei.com>
Date: Tue, 26 May 2020 18:08:05 +0800
Subject: [PATCH] net: fix IPv4 checksum
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 06602c671a5ee23f517456424b216b2427c4334c ]

0xffff is invalid for IPv4 checksum (RFC1624)

Fixes: 6006818cfb26 ("net: new checksum functions")

Signed-off-by: Hongzhi Guo <guohongzhi1 at huawei.com>
Reviewed-by: Morten Brørup <mb at smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz at 6wind.com>
---
 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b793..ece2e433c 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
 {
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;
 }
 
 /**
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-07-24 12:53:50.351818251 +0100
+++ 0045-net-fix-IPv4-checksum.patch	2020-07-24 12:53:48.259005938 +0100
@@ -1,4 +1,4 @@
-From 06602c671a5ee23f517456424b216b2427c4334c Mon Sep 17 00:00:00 2001
+From 430b02f1a047df789916fe0bcd980a3048d2c364 Mon Sep 17 00:00:00 2001
 From: Hongzhi Guo <guohongzhi1 at huawei.com>
 Date: Tue, 26 May 2020 18:08:05 +0800
 Subject: [PATCH] net: fix IPv4 checksum
@@ -6,10 +6,11 @@
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 8bit
 
+[ upstream commit 06602c671a5ee23f517456424b216b2427c4334c ]
+
 0xffff is invalid for IPv4 checksum (RFC1624)
 
 Fixes: 6006818cfb26 ("net: new checksum functions")
-Cc: stable at dpdk.org
 
 Signed-off-by: Hongzhi Guo <guohongzhi1 at huawei.com>
 Reviewed-by: Morten Brørup <mb at smartsharesystems.com>
@@ -19,7 +20,7 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
-index 4c4437a54..292f63fd7 100644
+index 1ceb7b793..ece2e433c 100644
 --- a/lib/librte_net/rte_ip.h
 +++ b/lib/librte_net/rte_ip.h
 @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)


More information about the stable mailing list