[dpdk-stable] patch 'sched: fix subport freeing' has been queued to stable release 19.11.4

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/26/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 748d2e4c16a67f83ae67ffaa35c2b6ec7b17f286 Mon Sep 17 00:00:00 2001
From: Hrvoje Habjanic <hrvoje.habjanic at zg.ht.hr>
Date: Tue, 26 May 2020 19:24:55 +0200
Subject: [PATCH] sched: fix subport freeing

[ upstream commit fbd8981cddf9ea558d5480cc3b02d3334482210f ]

In function rte_sched_subport_free, there is code to free all allocated
stuff related to scheduler subport.
First there are some checks, and in the end, rte_bitmap_free is called.

Now, rte_bitmap_free is a dummy function, and it just checks if
provided pointer to bitmap is valid or not. So, actual memory for
subport is not freed.

This patch fixes this by removing call to rte_bitmap_free, and
instead calling rte_free.

Fixes: d9213b829a31 ("sched: remove pipe params config from port level")

Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic at zg.ht.hr>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Jasvinder Singh <jasvinder.singh at intel.com>
---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index c0983ddda..f15a3b515 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -888,7 +888,7 @@ rte_sched_subport_free(struct rte_sched_port *port,
 		}
 	}
 
-	rte_bitmap_free(subport->bmp);
+	rte_free(subport);
 }
 
 void
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-07-24 12:53:50.429674275 +0100
+++ 0047-sched-fix-subport-freeing.patch	2020-07-24 12:53:48.267006087 +0100
@@ -1,8 +1,10 @@
-From fbd8981cddf9ea558d5480cc3b02d3334482210f Mon Sep 17 00:00:00 2001
+From 748d2e4c16a67f83ae67ffaa35c2b6ec7b17f286 Mon Sep 17 00:00:00 2001
 From: Hrvoje Habjanic <hrvoje.habjanic at zg.ht.hr>
 Date: Tue, 26 May 2020 19:24:55 +0200
 Subject: [PATCH] sched: fix subport freeing
 
+[ upstream commit fbd8981cddf9ea558d5480cc3b02d3334482210f ]
+
 In function rte_sched_subport_free, there is code to free all allocated
 stuff related to scheduler subport.
 First there are some checks, and in the end, rte_bitmap_free is called.
@@ -15,7 +17,6 @@
 instead calling rte_free.
 
 Fixes: d9213b829a31 ("sched: remove pipe params config from port level")
-Cc: stable at dpdk.org
 
 Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic at zg.ht.hr>
 Acked-by: Stephen Hemminger <stephen at networkplumber.org>