[dpdk-stable] patch 'eventdev: remove redundant reset on timer cancel' has been queued to stable release 19.11.4

luca.boccassi at gmail.com luca.boccassi at gmail.com
Fri Jul 24 13:59:00 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/26/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From d79a74d9bfe61030fbe46546f575d5028a839739 Mon Sep 17 00:00:00 2001
From: Phil Yang <phil.yang at arm.com>
Date: Tue, 7 Jul 2020 23:54:52 +0800
Subject: [PATCH] eventdev: remove redundant reset on timer cancel

[ upstream commit e84d9c62c671a502022a3a81358cac702d6f3a15 ]

There is no thread will access these impl_opaque data after timer
canceled. When new timer armed, it got refilled. So the cleanup
process is unnecessary.

Signed-off-by: Phil Yang <phil.yang at arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar at arm.com>
---
 lib/librte_eventdev/rte_event_timer_adapter.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
index 678be9f0a..af5087132 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter.c
+++ b/lib/librte_eventdev/rte_event_timer_adapter.c
@@ -1163,8 +1163,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter,
 		rte_mempool_put(sw->tim_pool, (void **)timp);
 
 		evtims[i]->state = RTE_EVENT_TIMER_CANCELED;
-		evtims[i]->impl_opaque[0] = 0;
-		evtims[i]->impl_opaque[1] = 0;
 
 		rte_smp_wmb();
 	}
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-07-24 12:53:52.480892713 +0100
+++ 0102-eventdev-remove-redundant-reset-on-timer-cancel.patch	2020-07-24 12:53:48.347007578 +0100
@@ -1,14 +1,14 @@
-From e84d9c62c671a502022a3a81358cac702d6f3a15 Mon Sep 17 00:00:00 2001
+From d79a74d9bfe61030fbe46546f575d5028a839739 Mon Sep 17 00:00:00 2001
 From: Phil Yang <phil.yang at arm.com>
 Date: Tue, 7 Jul 2020 23:54:52 +0800
 Subject: [PATCH] eventdev: remove redundant reset on timer cancel
 
+[ upstream commit e84d9c62c671a502022a3a81358cac702d6f3a15 ]
+
 There is no thread will access these impl_opaque data after timer
 canceled. When new timer armed, it got refilled. So the cleanup
 process is unnecessary.
 
-Cc: stable at dpdk.org
-
 Signed-off-by: Phil Yang <phil.yang at arm.com>
 Reviewed-by: Dharmik Thakkar <dharmik.thakkar at arm.com>
 ---
@@ -16,10 +16,10 @@
  1 file changed, 2 deletions(-)
 
 diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
-index 4ed301382..aa01b4d9f 100644
+index 678be9f0a..af5087132 100644
 --- a/lib/librte_eventdev/rte_event_timer_adapter.c
 +++ b/lib/librte_eventdev/rte_event_timer_adapter.c
-@@ -1167,8 +1167,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter,
+@@ -1163,8 +1163,6 @@ swtim_cancel_burst(const struct rte_event_timer_adapter *adapter,
  		rte_mempool_put(sw->tim_pool, (void **)timp);
  
  		evtims[i]->state = RTE_EVENT_TIMER_CANCELED;


More information about the stable mailing list