[dpdk-stable] [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param
Honnappa Nagarahalli
Honnappa.Nagarahalli at arm.com
Wed Jul 29 21:34:32 CEST 2020
<snip>
> Subject: RE: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the
> param
>
> > >
> > > When enqueue one element to the ring, the param "obj" should be the
> > > object to be added into the ring. The object is of type void*.
> >
> > I understand void * as a pointer to an object you don't know the type of.
> > I would keep the current description.
> >
> > Honnappa, Konstantin, Olivier ?
>
> I think current one is a bit cleaner.
+1, the existing documentation is fine.
> Konstantin
>
>
> >
> > >
> > > Fixes: af75078fece3 ("first public release")
> > > Cc: stable at dpdk.org
> > >
> > > Signed-off-by: Feifei Wang <feifei.wang2 at arm.com>
> > > Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
> > > ---
> > > lib/librte_ring/rte_ring.h | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
> > > index da17ed6d7..418536b61 100644
> > > --- a/lib/librte_ring/rte_ring.h
> > > +++ b/lib/librte_ring/rte_ring.h
> > > @@ -276,7 +276,7 @@ rte_ring_enqueue_bulk(struct rte_ring *r, void *
> const *obj_table,
> > > * @param r
> > > * A pointer to the ring structure.
> > > * @param obj
> > > - * A pointer to the object to be added.
> > > + * A pointer (object) to be added.
> >
> >
> > --
> > David Marchand
More information about the stable
mailing list