[dpdk-stable] patch 'net/avp: fix gcc 10 maybe-uninitialized warning' has been queued to LTS release 18.11.9

Kevin Traynor ktraynor at redhat.com
Fri Jun 5 20:24:01 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/10/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/4c1bf43e88215b0875dccbe21249cc6d7a330684

Thanks.

Kevin.

---
>From 4c1bf43e88215b0875dccbe21249cc6d7a330684 Mon Sep 17 00:00:00 2001
From: Kevin Traynor <ktraynor at redhat.com>
Date: Wed, 11 Mar 2020 11:32:59 +0000
Subject: [PATCH] net/avp: fix gcc 10 maybe-uninitialized warning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit ec87d3b2c2451ce0fa71f53f64987c68a0b3423c ]

gcc 10.0.1 reports:

../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’:
../drivers/net/avp/avp_ethdev.c:1791:24:
warning: ‘avp_bufs[count]’ may be used uninitialized in this function
 [-Wmaybe-uninitialized]
 1791 |   tx_bufs[i] = avp_bufs[count];
      |                ~~~~~~~~^~~~~~~
../drivers/net/avp/avp_ethdev.c:1791:24:
warning: ‘avp_bufs[count]’ may be used uninitialized in this function
 [-Wmaybe-uninitialized]

Fix by initializing the array.

Fixes: 295abce2d25b ("net/avp: add packet transmit functions")

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: Steven Webster <steven.webster at windriver.com>
---
 drivers/net/avp/avp_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 09388d05f8..c5dfb3cab7 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -1698,5 +1698,5 @@ avp_xmit_scattered_pkts(void *tx_queue,
 {
 	struct rte_avp_desc *avp_bufs[(AVP_MAX_TX_BURST *
-				       RTE_AVP_MAX_MBUF_SEGMENTS)];
+				       RTE_AVP_MAX_MBUF_SEGMENTS)] = {};
 	struct avp_queue *txq = (struct avp_queue *)tx_queue;
 	struct rte_avp_desc *tx_bufs[AVP_MAX_TX_BURST];
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-06-05 19:20:51.183073406 +0100
+++ 0004-net-avp-fix-gcc-10-maybe-uninitialized-warning.patch	2020-06-05 19:20:50.704043222 +0100
@@ -1 +1 @@
-From ec87d3b2c2451ce0fa71f53f64987c68a0b3423c Mon Sep 17 00:00:00 2001
+From 4c1bf43e88215b0875dccbe21249cc6d7a330684 Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit ec87d3b2c2451ce0fa71f53f64987c68a0b3423c ]
+
@@ -24 +25,0 @@
-Cc: stable at dpdk.org
@@ -33 +34 @@
-index cd747b6beb..1abe96ce50 100644
+index 09388d05f8..c5dfb3cab7 100644
@@ -36 +37 @@
-@@ -1695,5 +1695,5 @@ avp_xmit_scattered_pkts(void *tx_queue,
+@@ -1698,5 +1698,5 @@ avp_xmit_scattered_pkts(void *tx_queue,



More information about the stable mailing list