[dpdk-stable] patch 'net/softnic: fix memory leak for thread' has been queued to LTS release 18.11.9

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/10/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/55284b6b02af122f85940328ba8b17e21f719178

Thanks.

Kevin.

---
>From 55284b6b02af122f85940328ba8b17e21f719178 Mon Sep 17 00:00:00 2001
From: Jasvinder Singh <jasvinder.singh at intel.com>
Date: Mon, 27 Apr 2020 18:13:20 +0100
Subject: [PATCH] net/softnic: fix memory leak for thread

[ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ]

For sending request messages to data plane threads, the
caller invokes thread_msg_send_recv() function which never
returns null response. Thus, removed redundant check on
the returned response.

Coverity issue: 357717, 357772
Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline")

Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 drivers/net/softnic/rte_eth_softnic_thread.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c
index 4572adfa6a..e42784e4ca 100644
--- a/drivers/net/softnic/rte_eth_softnic_thread.c
+++ b/drivers/net/softnic/rte_eth_softnic_thread.c
@@ -268,6 +268,4 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic,
 	/* Send request and wait for response */
 	rsp = thread_msg_send_recv(softnic, thread_id, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
@@ -356,6 +354,4 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic,
 	/* Send request and wait for response */
 	rsp = thread_msg_send_recv(softnic, thread_id, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-06-05 19:20:51.653540402 +0100
+++ 0013-net-softnic-fix-memory-leak-for-thread.patch	2020-06-05 19:20:50.727042699 +0100
@@ -1 +1 @@
-From 22335d4348d4b4b615d5556947c0297e0fe5d79b Mon Sep 17 00:00:00 2001
+From 55284b6b02af122f85940328ba8b17e21f719178 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index d610b1617e..d61846e030 100644
+index 4572adfa6a..e42784e4ca 100644
@@ -25 +26 @@
-@@ -360,6 +360,4 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic,
+@@ -268,6 +268,4 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic,
@@ -32 +33 @@
-@@ -445,6 +443,4 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic,
+@@ -356,6 +354,4 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic,