[dpdk-stable] patch 'net/qede: fix link state configuration' has been queued to LTS release 18.11.9

Kevin Traynor ktraynor at redhat.com
Fri Jun 5 20:24:55 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/10/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/464774735cbd1937307fa579c2c1a76530194200

Thanks.

Kevin.

---
>From 464774735cbd1937307fa579c2c1a76530194200 Mon Sep 17 00:00:00 2001
From: Rasesh Mody <rmody at marvell.com>
Date: Wed, 13 May 2020 21:09:02 -0700
Subject: [PATCH] net/qede: fix link state configuration

[ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ]

Move link state enable/disable to dev_start() and dev_stop()
respectively. This will ensure when devices are stopped,
link status will be appropriately shown as down.

Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")

Signed-off-by: Shahed Shaikh <shshaikh at marvell.com>
Signed-off-by: Rasesh Mody <rmody at marvell.com>
Signed-off-by: Igor Russkikh <irusskikh at marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 791556dc52..340c35a1be 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1059,4 +1059,7 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
 		goto err;
 
+	/* Bring-up the link */
+	qede_dev_set_link_state(eth_dev, true);
+
 	/* Update link status */
 	qede_link_update(eth_dev, 0);
@@ -1080,4 +1083,10 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
 	PMD_INIT_FUNC_TRACE(edev);
 
+	/* Bring the link down */
+	qede_dev_set_link_state(eth_dev, false);
+
+	/* Update link status */
+	qede_link_update(eth_dev, 0);
+
 	/* Disable vport */
 	if (qede_activate_vport(eth_dev, false))
@@ -1452,6 +1461,4 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
 	eth_dev->data->nb_tx_queues = 0;
 
-	/* Bring the link down */
-	qede_dev_set_link_state(eth_dev, false);
 	qdev->ops->common->slowpath_stop(edev);
 	qdev->ops->common->remove(edev);
@@ -2552,7 +2559,4 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
 	}
 
-	/* Bring-up the link */
-	qede_dev_set_link_state(eth_dev, true);
-
 	adapter->num_tx_queues = 0;
 	adapter->num_rx_queues = 0;
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-06-05 19:20:53.995381414 +0100
+++ 0058-net-qede-fix-link-state-configuration.patch	2020-06-05 19:20:50.879039246 +0100
@@ -1 +1 @@
-From d789705873d47d70a3ba0a6a4dfb83fb629d3464 Mon Sep 17 00:00:00 2001
+From 464774735cbd1937307fa579c2c1a76530194200 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index e71fa1e6a7..0b1fca9aca 100644
+index 791556dc52..340c35a1be 100644
@@ -24 +25 @@
-@@ -1145,4 +1145,7 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
+@@ -1059,4 +1059,7 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
@@ -32 +33 @@
-@@ -1167,4 +1170,10 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
+@@ -1080,4 +1083,10 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
@@ -43 +44 @@
-@@ -1551,6 +1560,4 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
+@@ -1452,6 +1461,4 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
@@ -50,2 +51,2 @@
-@@ -2673,7 +2680,4 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
- 	eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;
+@@ -2552,7 +2559,4 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
+ 	}



More information about the stable mailing list