[dpdk-stable] patch 'app/testpmd: fix DCB set' has been queued to LTS release 18.11.9

Kevin Traynor ktraynor at redhat.com
Fri Jun 5 20:25:00 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/10/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/efcb7a83984c594d4a74b64ff73d989e58ce3fac

Thanks.

Kevin.

---
>From efcb7a83984c594d4a74b64ff73d989e58ce3fac Mon Sep 17 00:00:00 2001
From: Ting Xu <ting.xu at intel.com>
Date: Tue, 12 May 2020 10:13:56 +0000
Subject: [PATCH] app/testpmd: fix DCB set

[ upstream commit 5139bc12b0d133fd99d0a0c07f0c5a31cff0ac39 ]

When set DCB in testpmd, there is a segmentation fault. It is
because the local variable rss_conf in get_eth_dcb_conf()
is not cleared, so that the pointer member variable rss_key has
a random address, which leads to an error in the following
processing. This patch initialized the local variable rss_conf
to avoid this situation.

Fixes: ac7c491c3fec ("app/testpmd: fix DCB config")

Signed-off-by: Ting Xu <ting.xu at intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test-pmd/testpmd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b68bc54e32..a32eae750c 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2935,4 +2935,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
 				&eth_conf->tx_adv_conf.dcb_tx_conf;
 
+		memset(&rss_conf, 0, sizeof(struct rte_eth_rss_conf));
+
 		rc = rte_eth_dev_rss_hash_conf_get(pid, &rss_conf);
 		if (rc != 0)
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-06-05 19:20:54.260020473 +0100
+++ 0063-app-testpmd-fix-DCB-set.patch	2020-06-05 19:20:50.896038859 +0100
@@ -1 +1 @@
-From 5139bc12b0d133fd99d0a0c07f0c5a31cff0ac39 Mon Sep 17 00:00:00 2001
+From efcb7a83984c594d4a74b64ff73d989e58ce3fac Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5139bc12b0d133fd99d0a0c07f0c5a31cff0ac39 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index baccc3a495..4989d22ca8 100644
+index b68bc54e32..a32eae750c 100644
@@ -26 +27 @@
-@@ -3461,4 +3461,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
+@@ -2935,4 +2935,6 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,



More information about the stable mailing list