[dpdk-stable] patch 'eal/arm64: fix precise TSC' has been queued to stable release 19.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue May 19 14:53:20 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From bcf4069ff25cae1c135ed08af5db5bb4c2d4db4e Mon Sep 17 00:00:00 2001
From: Haifeng Lin <haifeng.lin at huawei.com>
Date: Thu, 12 Mar 2020 01:08:33 +0000
Subject: [PATCH] eal/arm64: fix precise TSC

[ upstream commit 754b6166f522f3fab2c6dd7949c9d1180aa1c7a9 ]

In order to get more accurate the cntvct_el0 reading,
SW must invoke isb.

Fixes: ccad39ea0712 ("eal/arm: add cpu cycle operations for ARMv8")

Reviewed-by: Gavin Hu <gavin.hu at arm.com>
Acked-by: Jerin Jacob <jerinj at marvell.com>
Signed-off-by: Haifeng Lin <haifeng.lin at huawei.com>
---
 lib/librte_eal/common/include/arch/arm/rte_cycles_64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h b/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
index 68e7c73384..da557b6a10 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_cycles_64.h
@@ -62,7 +62,7 @@ rte_rdtsc(void)
 static inline uint64_t
 rte_rdtsc_precise(void)
 {
-	rte_mb();
+	asm volatile("isb" : : : "memory");
 	return rte_rdtsc();
 }
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 13:56:19.239156381 +0100
+++ 0010-eal-arm64-fix-precise-TSC.patch	2020-05-19 13:56:18.175501026 +0100
@@ -1,13 +1,14 @@
-From 754b6166f522f3fab2c6dd7949c9d1180aa1c7a9 Mon Sep 17 00:00:00 2001
+From bcf4069ff25cae1c135ed08af5db5bb4c2d4db4e Mon Sep 17 00:00:00 2001
 From: Haifeng Lin <haifeng.lin at huawei.com>
 Date: Thu, 12 Mar 2020 01:08:33 +0000
 Subject: [PATCH] eal/arm64: fix precise TSC
 
+[ upstream commit 754b6166f522f3fab2c6dd7949c9d1180aa1c7a9 ]
+
 In order to get more accurate the cntvct_el0 reading,
 SW must invoke isb.
 
 Fixes: ccad39ea0712 ("eal/arm: add cpu cycle operations for ARMv8")
-Cc: stable at dpdk.org
 
 Reviewed-by: Gavin Hu <gavin.hu at arm.com>
 Acked-by: Jerin Jacob <jerinj at marvell.com>


More information about the stable mailing list