[dpdk-stable] patch 'net/sfc: fix reported promiscuous/multicast mode' has been queued to stable release 19.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue May 19 14:53:36 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 556cdccab20203c0f49086a9ec287b1508bdacf1 Mon Sep 17 00:00:00 2001
From: Andrew Rybchenko <arybchenko at solarflare.com>
Date: Wed, 4 Mar 2020 15:01:04 +0000
Subject: [PATCH] net/sfc: fix reported promiscuous/multicast mode

[ upstream commit 9d28d6b0b0bf4e7d9386c2ab56893d5cc95e78e5 ]

Requested promiscuous or all-multicast mode may be dropped on port
start if FW denies to enable it (e.g. because of no permission
in the case of VF). Return applied value on get.

Fixes: f5258439ee5d ("net/sfc: avoid failure on port start if Rx mode is rejected")

Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
---
 drivers/net/sfc/sfc_rx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c
index 7afd2c8b33..f589ece757 100644
--- a/drivers/net/sfc/sfc_rx.c
+++ b/drivers/net/sfc/sfc_rx.c
@@ -719,6 +719,7 @@ retry:
 		sfc_warn(sa, "promiscuous mode will be disabled");
 
 		port->promisc = B_FALSE;
+		sa->eth_dev->data->promiscuous = 0;
 		rc = sfc_set_rx_mode(sa);
 		if (rc != 0)
 			return rc;
@@ -732,6 +733,7 @@ retry:
 		sfc_warn(sa, "all-multicast mode will be disabled");
 
 		port->allmulti = B_FALSE;
+		sa->eth_dev->data->all_multicast = 0;
 		rc = sfc_set_rx_mode(sa);
 		if (rc != 0)
 			return rc;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 13:56:19.877104693 +0100
+++ 0026-net-sfc-fix-reported-promiscuous-multicast-mode.patch	2020-05-19 13:56:18.211501675 +0100
@@ -1,14 +1,15 @@
-From 9d28d6b0b0bf4e7d9386c2ab56893d5cc95e78e5 Mon Sep 17 00:00:00 2001
+From 556cdccab20203c0f49086a9ec287b1508bdacf1 Mon Sep 17 00:00:00 2001
 From: Andrew Rybchenko <arybchenko at solarflare.com>
 Date: Wed, 4 Mar 2020 15:01:04 +0000
 Subject: [PATCH] net/sfc: fix reported promiscuous/multicast mode
 
+[ upstream commit 9d28d6b0b0bf4e7d9386c2ab56893d5cc95e78e5 ]
+
 Requested promiscuous or all-multicast mode may be dropped on port
 start if FW denies to enable it (e.g. because of no permission
 in the case of VF). Return applied value on get.
 
 Fixes: f5258439ee5d ("net/sfc: avoid failure on port start if Rx mode is rejected")
-Cc: stable at dpdk.org
 
 Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
 ---


More information about the stable mailing list