[dpdk-stable] patch 'event/dsw: remove unnecessary read barrier' has been queued to stable release 19.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue May 19 14:54:17 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From b0843e567101508860040091b5c58e9b147b6975 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom at ericsson.com>
Date: Mon, 9 Mar 2020 07:51:05 +0100
Subject: [PATCH] event/dsw: remove unnecessary read barrier
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit cea7bc671311e8cf5fbc21dceb15f5f8af8ee36b ]

Remove unnecessary read barrier (and misleading comment) on control
message dequeue.

Fixes: f6257b22e767 ("event/dsw: add load balancing")

Suggested-by: Ola Liljedahl <ola.liljedahl at arm.com>
Signed-off-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>
---
 drivers/event/dsw/dsw_event.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index 8ea68cd966..10e44fd497 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -930,11 +930,6 @@ dsw_port_ctl_process(struct dsw_evdev *dsw, struct dsw_port *port)
 {
 	struct dsw_ctl_msg msg;
 
-	/* So any table loads happens before the ring dequeue, in the
-	 * case of a 'paus' message.
-	 */
-	rte_smp_rmb();
-
 	if (dsw_port_ctl_dequeue(port, &msg) == 0) {
 		switch (msg.type) {
 		case DSW_CTL_PAUS_REQ:
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 13:56:21.543998949 +0100
+++ 0067-event-dsw-remove-unnecessary-read-barrier.patch	2020-05-19 13:56:18.295503187 +0100
@@ -1,4 +1,4 @@
-From cea7bc671311e8cf5fbc21dceb15f5f8af8ee36b Mon Sep 17 00:00:00 2001
+From b0843e567101508860040091b5c58e9b147b6975 Mon Sep 17 00:00:00 2001
 From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom at ericsson.com>
 Date: Mon, 9 Mar 2020 07:51:05 +0100
 Subject: [PATCH] event/dsw: remove unnecessary read barrier
@@ -6,11 +6,12 @@
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 8bit
 
+[ upstream commit cea7bc671311e8cf5fbc21dceb15f5f8af8ee36b ]
+
 Remove unnecessary read barrier (and misleading comment) on control
 message dequeue.
 
 Fixes: f6257b22e767 ("event/dsw: add load balancing")
-Cc: stable at dpdk.org
 
 Suggested-by: Ola Liljedahl <ola.liljedahl at arm.com>
 Signed-off-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>
@@ -19,10 +20,10 @@
  1 file changed, 5 deletions(-)
 
 diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
-index c31a4c492f..94c8efdbcf 100644
+index 8ea68cd966..10e44fd497 100644
 --- a/drivers/event/dsw/dsw_event.c
 +++ b/drivers/event/dsw/dsw_event.c
-@@ -1065,11 +1065,6 @@ dsw_port_ctl_process(struct dsw_evdev *dsw, struct dsw_port *port)
+@@ -930,11 +930,6 @@ dsw_port_ctl_process(struct dsw_evdev *dsw, struct dsw_port *port)
  {
  	struct dsw_ctl_msg msg;
  


More information about the stable mailing list