[dpdk-stable] patch 'test: remove redundant macro' has been queued to stable release 19.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue May 19 15:02:18 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From ebad6ac59a05fc0e36da4b2fb94f76562961e803 Mon Sep 17 00:00:00 2001
From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Date: Thu, 9 Apr 2020 19:24:53 +0200
Subject: [PATCH] test: remove redundant macro

[ upstream commit 27ea35b743aa3c735d04848b5c795ae0b8cd311b ]

Remove RTE_TEST_TRACE_FAILURE macro definition from app/test/test.h
as it might be already defined and cause build problems.

Also it is good to leave the decision of additional logs to the final
user of test.h and rte_test.h

Fixes: 5afc521eac6a ("eal: add test assert macros")

Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
 app/test/test.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/test/test.h b/app/test/test.h
index ac0c50616c..b07f6c1ef0 100644
--- a/app/test/test.h
+++ b/app/test/test.h
@@ -22,8 +22,6 @@
 # define TEST_TRACE_FAILURE(_file, _line, _func)
 #endif
 
-#define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE
-
 #include <rte_test.h>
 
 #define TEST_ASSERT RTE_TEST_ASSERT
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:44.737045794 +0100
+++ 0003-test-remove-redundant-macro.patch	2020-05-19 14:04:44.048645327 +0100
@@ -1,8 +1,10 @@
-From 27ea35b743aa3c735d04848b5c795ae0b8cd311b Mon Sep 17 00:00:00 2001
+From ebad6ac59a05fc0e36da4b2fb94f76562961e803 Mon Sep 17 00:00:00 2001
 From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
 Date: Thu, 9 Apr 2020 19:24:53 +0200
 Subject: [PATCH] test: remove redundant macro
 
+[ upstream commit 27ea35b743aa3c735d04848b5c795ae0b8cd311b ]
+
 Remove RTE_TEST_TRACE_FAILURE macro definition from app/test/test.h
 as it might be already defined and cause build problems.
 
@@ -10,7 +12,6 @@
 user of test.h and rte_test.h
 
 Fixes: 5afc521eac6a ("eal: add test assert macros")
-Cc: stable at dpdk.org
 
 Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
 Acked-by: Akhil Goyal <akhil.goyal at nxp.com>


More information about the stable mailing list