[dpdk-stable] patch 'net/pfe: fix double free of MAC address' has been queued to stable release 19.11.3

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 670758fe8b981048653aec28701c3ebf0445775d Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Thu, 9 Apr 2020 09:59:00 +0800
Subject: [PATCH] net/pfe: fix double free of MAC address

[ upstream commit 497eb88c14481c262bfb4af3a7d2050d62e35295 ]

The 'mac_addrs' freeing has been moved to rte_eth_dev_release_port(),
so freeing 'mac_addrs' like this in pfe_eth_exit() is unnecessary and
will cause double free.

Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/pfe/pfe_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c
index 59b5b8387b..bdf2a7c76a 100644
--- a/drivers/net/pfe/pfe_ethdev.c
+++ b/drivers/net/pfe/pfe_ethdev.c
@@ -396,7 +396,6 @@ pfe_eth_exit(struct rte_eth_dev *dev, struct pfe *pfe)
 	/* Close the device file for link status */
 	pfe_eth_close_cdev(dev->data->dev_private);
 
-	rte_free(dev->data->mac_addrs);
 	rte_eth_dev_release_port(dev);
 	pfe->nb_devs--;
 }
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:47.105279461 +0100
+++ 0064-net-pfe-fix-double-free-of-MAC-address.patch	2020-05-19 14:04:44.220648445 +0100
@@ -1,14 +1,15 @@
-From 497eb88c14481c262bfb4af3a7d2050d62e35295 Mon Sep 17 00:00:00 2001
+From 670758fe8b981048653aec28701c3ebf0445775d Mon Sep 17 00:00:00 2001
 From: Yunjian Wang <wangyunjian at huawei.com>
 Date: Thu, 9 Apr 2020 09:59:00 +0800
 Subject: [PATCH] net/pfe: fix double free of MAC address
 
+[ upstream commit 497eb88c14481c262bfb4af3a7d2050d62e35295 ]
+
 The 'mac_addrs' freeing has been moved to rte_eth_dev_release_port(),
 so freeing 'mac_addrs' like this in pfe_eth_exit() is unnecessary and
 will cause double free.
 
 Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions")
-Cc: stable at dpdk.org
 
 Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
 Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>