[dpdk-stable] patch 'net/ixgbe: fix link status after port reset' has been queued to stable release 19.11.3

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From ca2ecc15f20193a74bd9e6a0c14162e48daade97 Mon Sep 17 00:00:00 2001
From: Shougang Wang <shougangx.wang at intel.com>
Date: Mon, 13 Apr 2020 01:38:39 +0000
Subject: [PATCH] net/ixgbe: fix link status after port reset

[ upstream commit dfcea7f90f703dabcb3589ea06070a228dbcef12 ]

It's a normal behavior to change the link status to up after
resetting the port. So it is unnecessary to set link down before
starting port, and changing the link state(link up/down) frequently
will cause link speed unstable.

Fixes: c3f2fbff78cf ("net/ixgbe: fix link status")

Signed-off-by: Shougang Wang <shougangx.wang at intel.com>
Acked-by: Qiming Yang <qiming.yang at intel.com>
Tested-by: Xueming Zhang <xuemingx.zhang at intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 89d0e1c66a..29b7501e0a 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1195,7 +1195,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
 	diag = ixgbe_bypass_init_hw(hw);
 #else
 	diag = ixgbe_init_hw(hw);
-	hw->mac.autotry_restart = false;
 #endif /* RTE_LIBRTE_IXGBE_BYPASS */
 
 	/*
@@ -1306,8 +1305,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
 	/* enable support intr */
 	ixgbe_enable_intr(eth_dev);
 
-	ixgbe_dev_set_link_down(eth_dev);
-
 	/* initialize filter info */
 	memset(filter_info, 0,
 	       sizeof(struct ixgbe_filter_info));
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:48.965781779 +0100
+++ 0110-net-ixgbe-fix-link-status-after-port-reset.patch	2020-05-19 14:04:44.368651128 +0100
@@ -1,15 +1,16 @@
-From dfcea7f90f703dabcb3589ea06070a228dbcef12 Mon Sep 17 00:00:00 2001
+From ca2ecc15f20193a74bd9e6a0c14162e48daade97 Mon Sep 17 00:00:00 2001
 From: Shougang Wang <shougangx.wang at intel.com>
 Date: Mon, 13 Apr 2020 01:38:39 +0000
 Subject: [PATCH] net/ixgbe: fix link status after port reset
 
+[ upstream commit dfcea7f90f703dabcb3589ea06070a228dbcef12 ]
+
 It's a normal behavior to change the link status to up after
 resetting the port. So it is unnecessary to set link down before
 starting port, and changing the link state(link up/down) frequently
 will cause link speed unstable.
 
 Fixes: c3f2fbff78cf ("net/ixgbe: fix link status")
-Cc: stable at dpdk.org
 
 Signed-off-by: Shougang Wang <shougangx.wang at intel.com>
 Acked-by: Qiming Yang <qiming.yang at intel.com>
@@ -19,10 +20,10 @@
  1 file changed, 3 deletions(-)
 
 diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
-index d26cf0ab9e..aa1e8aac51 100644
+index 89d0e1c66a..29b7501e0a 100644
 --- a/drivers/net/ixgbe/ixgbe_ethdev.c
 +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
-@@ -1197,7 +1197,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
+@@ -1195,7 +1195,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
  	diag = ixgbe_bypass_init_hw(hw);
  #else
  	diag = ixgbe_init_hw(hw);
@@ -30,7 +31,7 @@
  #endif /* RTE_LIBRTE_IXGBE_BYPASS */
  
  	/*
-@@ -1308,8 +1307,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
+@@ -1306,8 +1305,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
  	/* enable support intr */
  	ixgbe_enable_intr(eth_dev);