[dpdk-stable] patch 'mempool: remove inline functions from export list' has been queued to stable release 19.11.3

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 8426cebb497d7588ccb0ce7d717d8241466ef260 Mon Sep 17 00:00:00 2001
From: Fady Bader <fady at mellanox.com>
Date: Wed, 22 Apr 2020 10:37:44 +0300
Subject: [PATCH] mempool: remove inline functions from export list

[ upstream commit 036d82365e7e26adc5061cae49778f96c431e697 ]

The code didn't compile when using exported mempool functions
under Windows.

compilation error logs:
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_cache_flush
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_default_cache
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_generic_get
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_generic_put
lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals
clang: error: linker command failed with exit code 1120 (use -v to see invocation)

The cause was that there were some inline functions that were included
in the export list.
To solve this the functions, which are implemented in the header
and shouldn't be exported, were removed from rte_mempool_version.map
export list.

Fixes: 4b5062755aa7 ("mempool: allow user-owned cache")
Fixes: 656f2d3ede96 ("mempool: deprecate specific get and put functions")

Signed-off-by: Fady Bader <fady at mellanox.com>
Acked-by: Andrew Rybchenko <arybchenko at solarflare.com>
---
 lib/librte_mempool/rte_mempool_version.map | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map
index d002dfc46f..d67ed2e2b9 100644
--- a/lib/librte_mempool/rte_mempool_version.map
+++ b/lib/librte_mempool/rte_mempool_version.map
@@ -4,18 +4,14 @@ DPDK_20.0 {
 	rte_mempool_audit;
 	rte_mempool_avail_count;
 	rte_mempool_cache_create;
-	rte_mempool_cache_flush;
 	rte_mempool_cache_free;
 	rte_mempool_calc_obj_size;
 	rte_mempool_check_cookies;
 	rte_mempool_contig_blocks_check_cookies;
 	rte_mempool_create;
 	rte_mempool_create_empty;
-	rte_mempool_default_cache;
 	rte_mempool_dump;
 	rte_mempool_free;
-	rte_mempool_generic_get;
-	rte_mempool_generic_put;
 	rte_mempool_in_use_count;
 	rte_mempool_list_dump;
 	rte_mempool_lookup;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:49.248275586 +0100
+++ 0117-mempool-remove-inline-functions-from-export-list.patch	2020-05-19 14:04:44.388651490 +0100
@@ -1,8 +1,10 @@
-From 036d82365e7e26adc5061cae49778f96c431e697 Mon Sep 17 00:00:00 2001
+From 8426cebb497d7588ccb0ce7d717d8241466ef260 Mon Sep 17 00:00:00 2001
 From: Fady Bader <fady at mellanox.com>
 Date: Wed, 22 Apr 2020 10:37:44 +0300
 Subject: [PATCH] mempool: remove inline functions from export list
 
+[ upstream commit 036d82365e7e26adc5061cae49778f96c431e697 ]
+
 The code didn't compile when using exported mempool functions
 under Windows.
 
@@ -26,7 +28,6 @@
 
 Fixes: 4b5062755aa7 ("mempool: allow user-owned cache")
 Fixes: 656f2d3ede96 ("mempool: deprecate specific get and put functions")
-Cc: stable at dpdk.org
 
 Signed-off-by: Fady Bader <fady at mellanox.com>
 Acked-by: Andrew Rybchenko <arybchenko at solarflare.com>
@@ -35,7 +36,7 @@
  1 file changed, 4 deletions(-)
 
 diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map
-index 4fffd3ea41..695dd6e04f 100644
+index d002dfc46f..d67ed2e2b9 100644
 --- a/lib/librte_mempool/rte_mempool_version.map
 +++ b/lib/librte_mempool/rte_mempool_version.map
 @@ -4,18 +4,14 @@ DPDK_20.0 {