[dpdk-stable] patch 'net/softnic: fix memory leak for thread' has been queued to stable release 19.11.3

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 60dfeffc23ad872474da8ac65e1323e072705d8d Mon Sep 17 00:00:00 2001
From: Jasvinder Singh <jasvinder.singh at intel.com>
Date: Mon, 27 Apr 2020 18:13:20 +0100
Subject: [PATCH] net/softnic: fix memory leak for thread

[ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ]

For sending request messages to data plane threads, the
caller invokes thread_msg_send_recv() function which never
returns null response. Thus, removed redundant check on
the returned response.

Coverity issue: 357717, 357772
Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline")

Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 drivers/net/softnic/rte_eth_softnic_thread.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c
index d610b1617e..d61846e030 100644
--- a/drivers/net/softnic/rte_eth_softnic_thread.c
+++ b/drivers/net/softnic/rte_eth_softnic_thread.c
@@ -359,8 +359,6 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = thread_msg_send_recv(softnic, thread_id, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -444,8 +442,6 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic,
 
 	/* Send request and wait for response */
 	rsp = thread_msg_send_recv(softnic, thread_id, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:50.482343836 +0100
+++ 0148-net-softnic-fix-memory-leak-for-thread.patch	2020-05-19 14:04:44.472653013 +0100
@@ -1,8 +1,10 @@
-From 22335d4348d4b4b615d5556947c0297e0fe5d79b Mon Sep 17 00:00:00 2001
+From 60dfeffc23ad872474da8ac65e1323e072705d8d Mon Sep 17 00:00:00 2001
 From: Jasvinder Singh <jasvinder.singh at intel.com>
 Date: Mon, 27 Apr 2020 18:13:20 +0100
 Subject: [PATCH] net/softnic: fix memory leak for thread
 
+[ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ]
+
 For sending request messages to data plane threads, the
 caller invokes thread_msg_send_recv() function which never
 returns null response. Thus, removed redundant check on
@@ -10,7 +12,6 @@
 
 Coverity issue: 357717, 357772
 Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline")
-Cc: stable at dpdk.org
 
 Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
 Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>