[dpdk-stable] patch 'net/netvsc: do RSS across Rx queue only' has been queued to stable release 19.11.3

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From f815b93c27797ab45ba080d1715e195ecfdef994 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 30 Apr 2020 12:08:52 -0700
Subject: [PATCH] net/netvsc: do RSS across Rx queue only

[ upstream commit 019a28912bf0113566ed5599192973bc1a7cbb07 ]

If number of tx queues is greater than the number of rx queues;
the driver ends up allocating more channels than rx queues.
The problem is that the RSS indirection table is programmed such
that some packets will end up on a channel that would never be
polled. The fix is to limit the RSS indirection table by number
of rx queues not channels.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 46da5a4e81..15a085c849 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -575,7 +575,7 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 				 dev->data->nb_tx_queues);
 
 	for (i = 0; i < NDIS_HASH_INDCNT; i++)
-		hv->rss_ind[i] = i % hv->num_queues;
+		hv->rss_ind[i] = i % dev->data->nb_rx_queues;
 
 	hn_rss_hash_init(hv, rss_conf);
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:52.098175590 +0100
+++ 0185-net-netvsc-do-RSS-across-Rx-queue-only.patch	2020-05-19 14:04:44.532654101 +0100
@@ -1,8 +1,10 @@
-From 019a28912bf0113566ed5599192973bc1a7cbb07 Mon Sep 17 00:00:00 2001
+From f815b93c27797ab45ba080d1715e195ecfdef994 Mon Sep 17 00:00:00 2001
 From: Stephen Hemminger <stephen at networkplumber.org>
 Date: Thu, 30 Apr 2020 12:08:52 -0700
 Subject: [PATCH] net/netvsc: do RSS across Rx queue only
 
+[ upstream commit 019a28912bf0113566ed5599192973bc1a7cbb07 ]
+
 If number of tx queues is greater than the number of rx queues;
 the driver ends up allocating more channels than rx queues.
 The problem is that the RSS indirection table is programmed such
@@ -11,7 +13,6 @@
 of rx queues not channels.
 
 Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
-Cc: stable at dpdk.org
 
 Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
 ---
@@ -19,7 +20,7 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
-index 7bf5465ce5..60102362e1 100644
+index 46da5a4e81..15a085c849 100644
 --- a/drivers/net/netvsc/hn_ethdev.c
 +++ b/drivers/net/netvsc/hn_ethdev.c
 @@ -575,7 +575,7 @@ static int hn_dev_configure(struct rte_eth_dev *dev)