[dpdk-stable] patch 'net/ixgbe: fix link status synchronization on BSD' has been queued to stable release 19.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue May 19 15:05:24 CEST 2020


Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/21/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From f05c433b440fb20cccfa18ac0328f2ac9abdca60 Mon Sep 17 00:00:00 2001
From: Zhihong Peng <zhihongx.peng at intel.com>
Date: Thu, 16 Apr 2020 23:52:12 -0400
Subject: [PATCH] net/ixgbe: fix link status synchronization on BSD

[ upstream commit 0012111a3d879b0b0e27d14a841e2a729545727d ]

DPDK does not implement interrupt mechanism on BSD,
so force NIC status synchronization.

Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")

Signed-off-by: Zhihong Peng <zhihongx.peng at intel.com>
Tested-by: Zhimin Huang <zhiminx.huang at intel.com>
Acked-by: Xiaolong Ye <xiaolong.ye at intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 29b7501e0a..e0f59e307d 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4253,6 +4253,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 	if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
 		wait = 0;
 
+/* BSD has no interrupt mechanism, so force NIC status synchronization. */
+#ifdef RTE_EXEC_ENV_FREEBSD
+	wait = 1;
+#endif
+
 	if (vf)
 		diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
 	else
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-19 14:04:52.264636938 +0100
+++ 0189-net-ixgbe-fix-link-status-synchronization-on-BSD.patch	2020-05-19 14:04:44.540654246 +0100
@@ -1,13 +1,14 @@
-From 0012111a3d879b0b0e27d14a841e2a729545727d Mon Sep 17 00:00:00 2001
+From f05c433b440fb20cccfa18ac0328f2ac9abdca60 Mon Sep 17 00:00:00 2001
 From: Zhihong Peng <zhihongx.peng at intel.com>
 Date: Thu, 16 Apr 2020 23:52:12 -0400
 Subject: [PATCH] net/ixgbe: fix link status synchronization on BSD
 
+[ upstream commit 0012111a3d879b0b0e27d14a841e2a729545727d ]
+
 DPDK does not implement interrupt mechanism on BSD,
 so force NIC status synchronization.
 
 Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
-Cc: stable at dpdk.org
 
 Signed-off-by: Zhihong Peng <zhihongx.peng at intel.com>
 Tested-by: Zhimin Huang <zhiminx.huang at intel.com>
@@ -17,10 +18,10 @@
  1 file changed, 5 insertions(+)
 
 diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
-index aa1e8aac51..cf5f1fe709 100644
+index 29b7501e0a..e0f59e307d 100644
 --- a/drivers/net/ixgbe/ixgbe_ethdev.c
 +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
-@@ -4257,6 +4257,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
+@@ -4253,6 +4253,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
  	if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
  		wait = 0;
  


More information about the stable mailing list